Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T23074, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 21074 - Don't call $wgUser->getSkin() on OutputPage::getHeadScripts()

Summary:	Don't call $wgUser->getSkin() on OutputPage::getHeadScripts()

Status: RESOLVED FIXED Product: MediaWiki Classification: Unclassified Component: General/Unknown (Other open bugs) Version: 1.16.x Hardware: All All Importance: Normal enhancement (vote) Target Milestone: --- Assigned To: Nobody - You can work on this! URL: Whiteboard: Keywords: patch Depends on: Blocks:   Show dependency tree / graph		Reported: 2009-10-09 22:26 UTC by Platonides Modified: 2009-10-10 07:55 UTC (History) CC List: 1 user (show) wikibugs See Also: Web browser: --- Mobile Platform: --- Assignee Huggle Beta Tester: ---

Attachments Fix (422 bytes, patch) 2009-10-09 22:27 UTC, Platonides Details Add an attachment (proposed patch, testcase, etc.)

Description Platonides 2009-10-09 22:26:41 UTC OutputPage::getHeadScripts() calls $sk = $wgUser->getSkin();, which is unneeded, since the skin is already passed as $sk as parameter. Comment 1 Platonides 2009-10-09 22:27:16 UTC Created attachment 6656 [details] Fix Comment 2 Alexandre Emsenhuber [IAlex] 2009-10-10 07:55:09 UTC Fixed in r57608.