Last modified: 2009-11-01 21:54:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T22914, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 20914 - Negative numbers give error in form field of Type:Number


Summary:	Negative numbers give error in form field of Type:Number

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	SemanticForms (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal minor (vote)
Target Milestone:	---
Assigned To:	Yaron Koren

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2009-10-01 02:07 UTC by Cam Webb
Modified:	2009-11-01 21:54 UTC (History)
CC List:	1 user (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Cam Webb 2009-10-01 02:07:30 UTC

Just a small patch to allow negative numbers in Type:Number fields. 

For version 1.8.4 downloaded as tgz:

SemanticForms/includes/SF_FormUtils.inc

173c173
< 			if (field.value.match(/^[\d\.,]+$/)) {
---
> 			if (field.value.match(/^\-?[\d\.,]+$/)) {


Love the application.  Thanks for all your work.

Cam

Comment 1 Yaron Koren 2009-11-01 21:54:26 UTC

Thanks for this patch! It's hard to believe that SF didn't allow negative numbers up till now. I managed to just sneak this fix in to version 1.8.5.

Note You need to log in before you can comment on or make changes to this bug.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links