Last modified: 2010-07-22 12:01:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 20893 - Toolbar dialogs break when JS2 is enabled
Toolbar dialogs break when JS2 is enabled
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UsabilityInitiative (Other open bugs)
unspecified
Other Linux
: Normal major with 1 vote (vote)
: ---
Assigned To: Trevor Parscal
http://translatewiki.net/w/i.php?titl...
:
Depends on:
Blocks: 24493
  Show dependency treegraph
 
Reported: 2009-09-30 02:05 UTC by Purodha Blissenbach
Modified: 2010-07-22 12:01 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
The ui edit window right after klicking the "edit" link (68.99 KB, image/png)
2009-10-11 07:02 UTC, Purodha Blissenbach
Details
The ui edit window after 40 klicks on the unlabelled lonely symbol in the lowest row of the header block of the edit window (96.74 KB, image/png)
2009-10-11 07:05 UTC, Purodha Blissenbach
Details
The browsers "Help>About" window telling its name, version, and related informations (48.32 KB, image/png)
2009-10-11 07:09 UTC, Purodha Blissenbach
Details

Description Purodha Blissenbach 2009-09-30 02:05:11 UTC
While translating the the "Replace next" message, I was suspecting that it would likely rather mean "Replace this, and proceed to next", which is ususal in such cases, I wanted to verify either.
I could not, because the "Search/Replace" button in the UI extra buttons does nothing but widen the inner border of the edit window. More precisely, it adds 1 unit to the left and bottom borders, 2 units to the top border, and does not alter the left border each time it is clicked. Border color in my case is dark brown.
Comment 1 Roan Kattouw 2009-09-30 09:08:10 UTC
For clarity: do you mean that clicking the button doesn't show the dialog? This works for me in Firefox. Which browser are you using? Do you get any JS errors?

To clarify what "Replace next" does: it finds the next occurrence and replaces it, so it's more like "Find next and replace".
Comment 2 Roan Kattouw 2009-10-06 16:01:55 UTC
Closing as WORKSFORME. If this is still broken, please provide more details.
Comment 3 Purodha Blissenbach 2009-10-11 06:23:55 UTC
I do not remember which browser it was (not IE though, I am certain, I was on a Linux box),
Konqueror and Iceweasel (a Mozilla Firefox clone) are the more likely ones.
I did not get JS errors, else I had reported them.

> it finds the next occurrence and replaces
> it, so it's more like "Find next and replace

This appears pretty useless to me, because you do not see what is going to happen.

I want the order reversed: Find and mark an occurrence, and when I hit a button (either "no, thanks, show next"
or "Yes, do it, then show next") I want an action taken on the text. Also, I want to see as much as possible of
the surrounding text, which means, place the hit very close to the middle of the edit window for me to inspect.
This kind of behavior could be scheduled for another "search and replace" button, or offered depending on a
parameter in the user preferences, I'd suggest.

Reopening, since it did not work for me.

I am going to add more details asap.
Comment 4 Purodha Blissenbach 2009-10-11 07:02:58 UTC
Created attachment 6659 [details]
The ui edit window right after klicking the "edit" link
Comment 5 Purodha Blissenbach 2009-10-11 07:05:01 UTC
Created attachment 6660 [details]
The ui edit window after 40 klicks on the unlabelled lonely symbol in the lowest row of the header block of the edit window
Comment 6 Purodha Blissenbach 2009-10-11 07:09:15 UTC
Created attachment 6661 [details]
The browsers "Help>About" window telling its name, version, and related informations

As one can see, it was Iceweasel.
Comment 7 Purodha Blissenbach 2009-10-11 07:28:26 UTC
I tried the same edit with Konqueror on the same machine - it does not even show the new UI edit window head box.
Comment 8 Roan Kattouw 2009-10-11 13:39:39 UTC
(In reply to comment #3)
> I do not remember which browser it was (not IE though, I am certain, I was on a
> Linux box),
> Konqueror and Iceweasel (a Mozilla Firefox clone) are the more likely ones.
> I did not get JS errors, else I had reported them.
> 
> > it finds the next occurrence and replaces
> > it, so it's more like "Find next and replace
> 
> This appears pretty useless to me, because you do not see what is going to
> happen.
> 
> I want the order reversed: Find and mark an occurrence, and when I hit a button
> (either "no, thanks, show next"
> or "Yes, do it, then show next") I want an action taken on the text. Also, I
> want to see as much as possible of
> the surrounding text, which means, place the hit very close to the middle of
> the edit window for me to inspect.
> This kind of behavior could be scheduled for another "search and replace"
> button, or offered depending on a
> parameter in the user preferences, I'd suggest.
> 
This discussion of having a "Replace" instead of a "Replace next" button is at bug 20919.
Comment 9 Roan Kattouw 2009-10-11 13:48:36 UTC
(In reply to comment #3)
> I do not remember which browser it was (not IE though, I am certain, I was on a
> Linux box),
> Konqueror and Iceweasel (a Mozilla Firefox clone) are the more likely ones.
> I did not get JS errors, else I had reported them.
> 
Turns out there was one after all: $j("#edittoolbar-link-tabs").tabs is not a function

This is caused by translatewiki having JS2 enabled, which the UsabilityInitiative extension currently doesn't work nicely with. I'm sure this makes it a dupe, but I can't find the original; updating summary instead.
Comment 10 Roan Kattouw 2009-10-11 19:45:21 UTC
Fixed in r57645.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links