Last modified: 2012-04-13 15:18:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T22851, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 20851 - AbuseFilter: "Lines added in edit" (added_lines) shows old lines, not added; same oddity for "unified diff" (edit_diff) and "Lines removed in edit" (removed_lines)
AbuseFilter: "Lines added in edit" (added_lines) shows old lines, not added; ...
Status: RESOLVED DUPLICATE of bug 20310
Product: MediaWiki extensions
Classification: Unclassified
AbuseFilter (Other open bugs)
unspecified
All All
: Low enhancement with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
http://als.wikipedia.org/w/index.php?...
: code-update-regression, testme
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2009-09-28 13:58 UTC by Melancholie
Modified: 2012-04-13 15:18 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Melancholie 2009-09-28 13:58:24 UTC
Comment 1 Melancholie 2009-09-28 14:05:02 UTC 
Sorry, pressed enter accidentally.

AbuseFilter: "Lines added in edit" (added_lines) shows old lines, not added on the specific edit.

Sometimes the whole page content is shown, sometimes on or two lines before and after the added line(s).
It's the same oddity for "Unified diff of changes made by edit" (edit_diff) and for "Lines removed in edit" (removed_lines).
Comment 2 Melancholie 2009-09-28 14:14:10 UTC 
Examples:
* http://als.wikipedia.org/w/index.php?title=Special:AbuseFilter&details=616&uselang=en
  L ... shows full text content for added_lines, removed_lines and edit_diff although the actual diff is showing a one-line change.
* http://als.wikipedia.org/w/index.php?title=Special:AbuseFilter&details=610&uselang=en
  L ... showed one additional line in added_lines and removes it in removed_lines. See edit_diff: where does this additional "---" line come from? Compare actual diff.
* http://als.wikipedia.org/w/index.php?title=Special:AbuseFilter&details=583&uselang=en
  L ... showed the same like the first (latest/current) example.

This happens since the last big code update.
Comment 4 Beau 2011-08-20 20:19:45 UTC 

*** This bug has been marked as a duplicate of bug 19716 ***
Comment 5 Kleiner 2011-10-16 03:26:39 UTC 
This problem has been seen by me a couple of days ago. As I'm not sure if this bug is really a duplicate from bug 19716, I guess I should report it again:

Please, compare the value of added_lines and removed_lines variables with the actual diff on this case:

* Actual diff: https://pt.wikipedia.org/w/index.php?title=Alexis_Texas&diff=27267727&oldid=27110744
* Abuse log: https://pt.wikipedia.org/wiki/Especial:AbuseLog/864451

What I've found particulary odd was that this problem occured only with some edits, and mostly with bots edits, although at time the code wasn't filtering by user group (I've even added a user group condition, thinking at first this could be the problem, though it not seems the case now).

If it is actually a duplicate of bug 19716, I'm anticipating my apologies.
Comment 6 Beau 2012-04-13 15:18:46 UTC 

*** This bug has been marked as a duplicate of bug 20310 ***
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links