Last modified: 2013-03-26 11:24:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T22766, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 20766 - Bogus "all:" namespace appears in "Did you mean..." when all namespaces selected in preferences
Bogus "all:" namespace appears in "Did you mean..." when all namespaces selec...
Status: CLOSED WORKSFORME
Product: Wikimedia
Classification: Unclassified
lucene-search-2 (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Robert Stojnic
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-09-22 15:12 UTC by Dan Barrett
Modified: 2013-03-26 11:24 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Dan Barrett 2009-09-22 15:12:12 UTC
In the "Did you mean..." suggestion on the search results page, the namespace "All:" sometimes gets prepended to the search term.  This bad behavior happens only if the user has checked all of the namespaces checkboxes in My Preferences on the Search tab.

Environment: Lucene 2.1, MWSearch (r45173), MediaWiki 1.15.1.

Test case: search for "Superma"

Correct behavior: "Did you mean: Superman" is displayed

Observed behavior: "Did you mean: All:Superman" is displayed

To make the bug occur, go to My Preferences, click the Search tab, check all namespace checkboxes, and save.  To make the bug go away, uncheck ANY namespace checkbox and save.
Comment 1 Dan Barrett 2009-09-22 15:13:43 UTC
If it makes a difference, we have a bunch of custom namespaces defined: 100, 101, and 200-207.

Comment 2 Robert Stojnic 2009-09-22 15:57:51 UTC
This has been fixed some time ago in r50208. 
Comment 3 Dan Barrett 2009-09-22 16:09:47 UTC
Thanks. I had downloaded the 1.15.x snapshot of MWSearch. I just downloaded from trunk and it works fine.
Comment 4 Dan Barrett 2009-09-22 16:11:54 UTC
I spoke too soon: MWSearch trunk doesn't work with MW 1.15.1.  "PHP Fatal error:  Call to undefined method Language::getNamespaceAliases() in /var/www/html/vistaprint/extensions/MWSearch/MWSearch_body.php on line 94".
Comment 5 Robert Stojnic 2009-09-22 16:20:13 UTC
The trunk is designed to work with latest MediaWiki. You could try reverting r52664 to suppress that error, or get an earlier MWSearch snapshot. 
Comment 6 Dan Barrett 2009-09-22 18:02:37 UTC
Thanks Robert. The 1.15.x snapshot is buggy (which is the reason for this ticket) so I manually changed "getNamespaceAliases()" to "namespaceAliases" and that cleared up the problem. This ought to hold us until 1.16 is released.
Comment 7 Andre Klapper 2013-03-26 11:24:23 UTC
[Merging "MediaWiki extensions/Lucene Search" into "Wikimedia/lucene-search2", see bug 46542. You can filter bugmail for: search-component-merge-20130326 ]

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links