Last modified: 2009-09-20 20:40:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T22726, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 20726 - Title::getLatestRevID function documentation is incorrect
Title::getLatestRevID function documentation is incorrect
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Documentation (Other open bugs)
1.16.x
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
http://svn.wikimedia.org/viewvc/media...
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2009-09-18 17:06 UTC by Christian Neubauer
Modified: 2009-09-20 20:40 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Christian Neubauer 2009-09-18 17:06:17 UTC 
In Title.php in the getLatestRevID() function, the function documentation claims that it returns an int.  However, it returns the result of a call to Database->selectField which will return false in a couple of cases, mainly, if the page doesn't exist.

The documentation for the function should be updated to say it returns a Boolean or an Int or the result of the selectField call should be checked and 0 returned if its false.
Comment 1 Alexandre Emsenhuber [IAlex] 2009-09-20 20:40:28 UTC 
Done in r56685.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links