Last modified: 2006-08-04 18:15:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 2069 - Merge the LanguageUtf8 class into the Language class
Merge the LanguageUtf8 class into the Language class
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Internationalization (Other open bugs)
1.7.x
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 6173 (view as bug list)
Depends on:
Blocks: code_quality
  Show dependency treegraph
 
Reported: 2005-05-04 19:42 UTC by Ævar Arnfjörð Bjarmason
Modified: 2006-08-04 18:15 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch (trunk) (63.75 KB, patch)
2006-06-03 07:10 UTC, Rotem Liss
Details
Second Patch (trunk) (57.32 KB, patch)
2006-06-09 16:05 UTC, Rotem Liss
Details
Patch (trunk) (64.70 KB, patch)
2006-06-10 08:18 UTC, Rotem Liss
Details
Patch v2 (trunk) (67.56 KB, patch)
2006-06-11 14:15 UTC, Rotem Liss
Details
Patch v3 (trunk) (67.68 KB, patch)
2006-06-11 17:16 UTC, Rotem Liss
Details
Patch v4 (trunk) (67.79 KB, patch)
2006-06-11 17:23 UTC, Rotem Liss
Details
Patch v5 (trunk) (67.66 KB, patch)
2006-06-15 14:55 UTC, Rotem Liss
Details
Patch v6 (trunk) (67.75 KB, patch)
2006-06-16 20:00 UTC, Rotem Liss
Details

Description Ævar Arnfjörð Bjarmason 2005-05-04 19:42:55 UTC
Since we'll be going UTF8-only for 1.5 the LanguageUtf8 will become redundant,
it should be merged into the main Language class.
Comment 1 Brion Vibber 2005-06-06 00:55:42 UTC
Not a 1.5 blocker, as it makes no functional difference.
Comment 2 Brion Vibber 2006-06-02 18:57:14 UTC
*** Bug 6173 has been marked as a duplicate of this bug. ***
Comment 3 Rotem Liss 2006-06-03 07:10:20 UTC
Created attachment 1884 [details]
Patch (trunk)

See Bug 6173 for explanations. When applying the patch, also delete
languages/LanguageUtf8.php.
Comment 4 Rotem Liss 2006-06-09 16:05:50 UTC
Created attachment 1922 [details]
Second Patch (trunk)

The first patch was partially applied, this patch includes the changes in all
the other language files. LanguageUtf8.php may be deleted.
Comment 5 Rotem Liss 2006-06-09 16:06:29 UTC
I've checked it carefully.
Comment 6 Rotem Liss 2006-06-10 08:18:32 UTC
Created attachment 1926 [details]
Patch (trunk)

Brion has reverted the patch in r14693, saying:

"Revert bad patch for (bug 2069) Merge the LanguageUtf8 class into the Language
class"

The most updated patch, which I have carefully checked and which is suited to
the current revision – r14697 (the patch will be updated if other language
files are restructured), is is now available for checking. As usual, the file
"languages/LanguageUtf8.php" should be deleted when checking the patch.

Brion: what is wrong with this patch (or with the commit in r14684), and what
is to do in order to fix it?
Comment 7 Brion Vibber 2006-06-10 21:31:22 UTC
It caused fatal errors when running Special:Version (and likely 
elsewhere, though we reverted it right quick after several 
thousand fatal errors spewed through the log).
Comment 8 Rotem Liss 2006-06-11 12:06:01 UTC
(In reply to comment #7)
> It caused fatal errors when running Special:Version (and likely 
> elsewhere, though we reverted it right quick after several 
> thousand fatal errors spewed through the log).

Ah, the following line is the problem (SpecialVersion::compare,
includes/SpecialVersion.php):

            return LanguageUtf8::lc( $a['name'] ) > LanguageUtf8::lc( $b['name']
) ? 1 : -1;

LanguageUtf8 should be replaced with Language. I will create a patch includes
that fix later, and will look at the code to see if there are other problems.
Comment 9 Rotem Liss 2006-06-11 14:15:39 UTC
Created attachment 1934 [details]
Patch v2 (trunk)

OK, *this* patch was carefully checked by me (I've visited each of the special
pages and action pages – action=delete, action=history, etc. – to see if
there are some errors), and now produces no error in Special:Version. Also,
I've carefully searched the whole code (all the pages in each folder) and fixed
each occurrence of LanguageUtf8, so now there should be no problem.
Comment 10 Rotem Liss 2006-06-11 17:16:22 UTC
Created attachment 1935 [details]
Patch v3 (trunk)

Updating the patch for LanguageLa.php and LanguageBe.php.
Comment 11 Rotem Liss 2006-06-11 17:23:27 UTC
Created attachment 1936 [details]
Patch v4 (trunk)

Updating the patch for LanguageNl.php.
Comment 12 Rotem Liss 2006-06-15 14:55:26 UTC
Created attachment 1956 [details]
Patch v5 (trunk)

Updates, so that the patch will not cause failures when using the "patch"
utility.
Comment 13 Rotem Liss 2006-06-16 20:00:03 UTC
Created attachment 1971 [details]
Patch v6 (trunk)

Fixing the line numbers.
Comment 14 Rotem Liss 2006-08-04 18:15:05 UTC
Already done by Tim Starling in the localisation-work branch, added to trunk in
r15823.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links