Last modified: 2006-08-04 18:15:05 UTC
Since we'll be going UTF8-only for 1.5 the LanguageUtf8 will become redundant,
it should be merged into the main Language class.
Not a 1.5 blocker, as it makes no functional difference.
*** Bug 6173 has been marked as a duplicate of this bug. ***
Created attachment 1884 [details]
See Bug 6173 for explanations. When applying the patch, also delete
Created attachment 1922 [details]
Second Patch (trunk)
The first patch was partially applied, this patch includes the changes in all
the other language files. LanguageUtf8.php may be deleted.
I've checked it carefully.
Created attachment 1926 [details]
Brion has reverted the patch in r14693, saying:
"Revert bad patch for (bug 2069) Merge the LanguageUtf8 class into the Language
The most updated patch, which I have carefully checked and which is suited to
the current revision – r14697 (the patch will be updated if other language
files are restructured), is is now available for checking. As usual, the file
"languages/LanguageUtf8.php" should be deleted when checking the patch.
Brion: what is wrong with this patch (or with the commit in r14684), and what
is to do in order to fix it?
It caused fatal errors when running Special:Version (and likely
elsewhere, though we reverted it right quick after several
thousand fatal errors spewed through the log).
(In reply to comment #7)
> It caused fatal errors when running Special:Version (and likely
> elsewhere, though we reverted it right quick after several
> thousand fatal errors spewed through the log).
Ah, the following line is the problem (SpecialVersion::compare,
return LanguageUtf8::lc( $a['name'] ) > LanguageUtf8::lc( $b['name']
) ? 1 : -1;
LanguageUtf8 should be replaced with Language. I will create a patch includes
that fix later, and will look at the code to see if there are other problems.
Created attachment 1934 [details]
Patch v2 (trunk)
OK, *this* patch was carefully checked by me (I've visited each of the special
pages and action pages – action=delete, action=history, etc. – to see if
there are some errors), and now produces no error in Special:Version. Also,
I've carefully searched the whole code (all the pages in each folder) and fixed
each occurrence of LanguageUtf8, so now there should be no problem.
Created attachment 1935 [details]
Patch v3 (trunk)
Updating the patch for LanguageLa.php and LanguageBe.php.
Created attachment 1936 [details]
Patch v4 (trunk)
Updating the patch for LanguageNl.php.
Created attachment 1956 [details]
Patch v5 (trunk)
Updates, so that the patch will not cause failures when using the "patch"
Created attachment 1971 [details]
Patch v6 (trunk)
Fixing the line numbers.
Already done by Tim Starling in the localisation-work branch, added to trunk in