Last modified: 2009-09-25 22:26:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T22677, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 20677 - bug in uploading new version on commons
bug in uploading new version on commons
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Uploading (Other open bugs)
1.16.x
All All
: Normal major with 8 votes (vote)
: ---
Assigned To: Bryan Tong Minh
: code-update-regression
: 20750 (view as bug list)
Depends on:
Blocks: 20815
  Show dependency treegraph
 
Reported: 2009-09-17 10:15 UTC by JAn Dudík
Modified: 2009-09-25 22:26 UTC (History)
25 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Upload new version (46.00 KB, image/jpeg)
2009-09-18 09:16 UTC, Melos
Details

Description JAn Dudík 2009-09-17 10:15:58 UTC
with version 1.16alpha-wmf (r56482) I am not able to upload nev version of file to commons. It says that file with this name exists.

{{cs}} 
Soubor s tímto názvem již existuje ve sdíleném úložišti. Pokud přesto chcete váš soubor načíst, vraťte se a zvolte jiný název.
File:$1
$1
Comment 1 Zil 2009-09-17 14:18:45 UTC
Also, if the page of the file has been deleted but there was no file, we get this kind of message : <Failed to calculate file hash; may be missing or damaged. Filename: mwrepo://local/temp/5/5a/20090917141156!Anthony_Bloomberg.jpg>
And upload is not possible.
Comment 2 Huib abigor Laurens 2009-09-17 16:56:30 UTC
I just tried to upload a newer version over a old photograph but I didn't get a error, I guess this problem is already fixed or was only a temporary problem?!

Comment 3 Chad H. 2009-09-17 17:18:08 UTC
CC'ing Michael, probably new-upload regression?
Comment 4 Michael Dale 2009-09-17 18:10:37 UTC
I am also having trouble reproducing the error locally or on commons.  
Comment 5 Simon 2009-09-17 18:31:04 UTC
I just tried after reporting it wouldn't work earlier and it's still giving me the same error. 
Comment 6 Michael Dale 2009-09-17 18:52:52 UTC
...I have been able to recreate the delete then re-upload issue on commons but not locally... maybe an issue with the file-system setup on commons? or differences from trunk and wmf deploy>... doing some more testing. 
Comment 7 Brion Vibber 2009-09-17 18:57:06 UTC
Steps for me to reproduce the has problem:

1) go to http://en.wikipedia.org/wiki/File:Long_leg_hair.jpg

2) save the image to local disk

3) hit "Upload a new version of this image"

4) Select the saved file from disk

5) *uncheck* 'Ignore warnings'

6) Click through the duplicate file warning

7) get <Failed to calculate file hash; may be missing or damaged. Filename: mwrepo://local/temp/a/ad/20090917185303!Long_leg_hair.jpg>
Retrieved from "http://en.wikipedia.org/wiki/Special:Upload"

If I leave 'Ignore warnings' checked the file goes through on a single step; possibly the temporary file isn't getting moved properly into the uploads temp directory, so the next request can't find it. Or there may be something else wrong with the session handling.


Haven't seen the commons dupe warning, though.
Comment 8 Michael Dale 2009-09-17 19:50:34 UTC
btongminh fixed in r56557 ... I did not have extensions like (fileBlacklist) installed locally (do now). Was an issue with virtual url being passed to the hook instead of the real url. We now init uploadFromStash with the real file url. 
Comment 9 Zil 2009-09-17 20:10:51 UTC
I tried to upload the flickr image here : http://www.flickr.com/photos/joaomaximo/3339447124/ on the page here http://commons.wikimedia.org/wiki/File:2009_8_049_Kenya_Wasini_island.jpg using the upload it, now... And it doesn't work. Does the fiw has been loaded on Wikimedia servers ?
Comment 10 Bryan Tong Minh 2009-09-17 20:11:46 UTC
Now it does. Please try again.
Comment 11 Zil 2009-09-17 20:19:22 UTC
I'd just try again. When I specify every thing on the upload form and click upload file, it goes back to the upload form without loading the file.
Comment 12 Bryan Tong Minh 2009-09-17 20:34:31 UTC
Flickr Upload Bot is a toolserver service and not a MediaWiki function.
Comment 13 Zil 2009-09-17 20:41:19 UTC
It is not while using Flickr Upload Bot. I create the page with the bot and the bot seems to have an issue with the upgrade.

BUT I tried then to upload it from the commons interface. Going to this page : http://commons.wikimedia.org/wiki/File:2009_8_049_Kenya_Wasini_island.jpg Clicking on upload it and then specify a local file (that came from this page http://www.flickr.com/photos/joaomaximo/3339447124/) I test with or without checking the Ignore all warning... 

Then, it just go back to the upload form. Without loading the file or providing an error.
Comment 14 Bryan Tong Minh 2009-09-17 20:49:27 UTC
(In reply to comment #13)
> It is not while using Flickr Upload Bot. I create the page with the bot and the
> bot seems to have an issue with the upgrade.
> 
Yes, but that is an issue with the bot and not with MediaWiki, so this is not the appropriate forum for this. In any case I have fixed this issue with the bot.
Comment 15 Zil 2009-09-17 20:59:05 UTC
(In reply to comment #14)
> (In reply to comment #13)
> > It is not while using Flickr Upload Bot. I create the page with the bot and the
> > bot seems to have an issue with the upgrade.
> > 
> Yes, but that is an issue with the bot and not with MediaWiki, so this is not
> the appropriate forum for this. In any case I have fixed this issue with the
> bot.
> 

I'm not speaking about the bot. Did you read : 

>>BUT I tried then to upload it from the commons interface. Going to this page :
>>http://commons.wikimedia.org/wiki/File:2009_8_049_Kenya_Wasini_island.jpg
>>Clicking on upload it and then specify a local file (that came from this page
>>http://www.flickr.com/photos/joaomaximo/3339447124/) I test with or without
>>checking the Ignore all warning... 

>>Then, it just go back to the upload form. Without loading the file or providing
>>an error.
Comment 16 Mila Zinkova 2009-09-18 00:24:53 UTC
It still does not work in Commons. I cannot overwrite my file with a new version.
Comment 17 Zil 2009-09-18 00:55:17 UTC
I tried to upload manually (without using a bot) the pictures in this cat : http://commons.wikimedia.org/wiki/Category:Image_pages_created_for_Flickr_upload_bot_without_files but I've got the same issue as before.

My process :

1) I donwload the file from flickr page

2) I go to the file page.

3) As there is no file, I've got this message : "No file by this name exists, but you can upload it."

4) I click on upload it.

5) I arrived on the classical commons upload form.

6) I click on Browse.

7) I select the file.

8) I click on Upload file.

9) I go back to step 5 without error message or warning or upload of the file.
Comment 18 Melos 2009-09-18 09:16:47 UTC
Created attachment 6562 [details]
Upload new version
Comment 19 Melos 2009-09-18 09:17:49 UTC
On itwiki autoconfirmed user can't upload a new file version (see attachment for error details), no problem instead with sysop rights. 
Is it related to this bug or it is a separate issue? Thanks (sorry for double comment)
Comment 20 Cecil 2009-09-18 12:11:30 UTC
Just got the same complaint from an user at dewiki. But as an admin I am able to upload new versions on Commons (not tested on dewiki).
Comment 21 mycae 2009-09-18 13:33:32 UTC
CCing -- I have seen this a few times now.
Comment 22 Zil 2009-09-18 17:46:09 UTC
It is confirmed that on Commons, it's the same bug. Admins could upload a new version, other users can't.
Comment 23 Bryan Tong Minh 2009-09-18 19:48:10 UTC
(In reply to comment #19)
> On itwiki autoconfirmed user can't upload a new file version (see attachment
> for error details), no problem instead with sysop rights. 
> Is it related to this bug or it is a separate issue? Thanks (sorry for double
> comment)
> 

It is a different issue. I thought this restriction was in place before the new code as well, but please correct me if I'm wrong: Users can not upload an image which also exists under the same name as on Commons. Was this the previous situation as well?
Comment 24 Bryan Tong Minh 2009-09-18 20:02:57 UTC
(In reply to comment #17)
> I tried to upload manually (without using a bot) the pictures in this cat :
> http://commons.wikimedia.org/wiki/Category:Image_pages_created_for_Flickr_upload_bot_without_files
> but I've got the same issue as before.
> 
It appears to be a problem with Commons' Javascript hacks; if I disable JavaScript it works. I will investigate further, but this is not an issue with MediaWiki core.
Comment 25 Lupo 2009-09-18 21:22:30 UTC
I don't think so. It fails for me (when I log in as a normal user) also with JavaScript completely disabled. Bryan suspected it had something to do with wpSourceType not being sent, but I verified this using Firebug: the POST request does contain that field, and in fact looks identical, whether commons:MediaWiki:UploadForm.js is used or not.

As I'm offline from now until mid-October, I'm afraid I cannot help more in tracking this down.
Comment 26 Bryan Tong Minh 2009-09-18 21:33:00 UTC
The wpSourceType issue was fixed by assuming wpSourceType=file by default. The problem now however is wpEditToken, which is not sent on reuploads (as indicated by Firebug).
Comment 27 Lejonel 2009-09-18 21:36:39 UTC
Maybe the problem described in comment #0 can be temporarily "fixed" by giving autoconfirmed users on Commons the "reupload-shared" right. Admins have this right and they do not seem to have problems with uploading new versions of files. That right should not be needed on Commons. But the error message in comment #0 is the Czech version of [[MediaWiki:Fileexists-shared-forbidden]], which is what users without that right on other projects get when they try to locally upload filenames that exists on Commons.
Comment 28 Bryan Tong Minh 2009-09-18 21:38:59 UTC
(In reply to comment #27)
> Maybe the problem described in comment #0 can be temporarily "fixed" by giving
> autoconfirmed users on Commons the "reupload-shared" right. Admins have this
> right and they do not seem to have problems with uploading new versions of
> files. That right should not be needed on Commons. But the error message in
> comment #0 is the Czech version of [[MediaWiki:Fileexists-shared-forbidden]],
> which is what users without that right on other projects get when they try to
> locally upload filenames that exists on Commons.
> 

As described in comment #23, this is a feature, not a bug. However if the previous behaviour was different, we could consider giving reupload-shared to autoconfirmed by default.
Comment 29 Lejonel 2009-09-18 22:32:44 UTC
(In reply to comment #28)
> As described in comment #23, this is a feature, not a bug. However if the
> previous behaviour was different, we could consider giving reupload-shared to
> autoconfirmed by default.

It is definitely a bug on Commons. Autoconfirmed users have always been able to reupload files there, since they have the "reupload" right. The "reupload-shared" right and associated MediaWiki messages should not have any meaning there.
But since the error message is displayed I thought that giving the right to more users may be a temporary workaround for the problem.

There seems to be similar problems on other wikis. Comment #19 is about reuploading a file at itwiki.
If the filename already exists at Commons the behaviour is expected. Only admins should be able to upload the file locally, and the feature works (almost, the error message should display the filename in place of $1, but that would probably be another bug).
But if the filename only exists at itwiki, then previous behaviour was that autoconfirmed users could reupload it. And the new behaviour is a bug similar to what is described in comment #0 on Commons. (The problem described in #1 looks a bit different. And I dont know if it may be related). 
Comment 30 Melos 2009-09-18 22:50:01 UTC
(In reply to comment #23)
> (In reply to comment #19)
> > On itwiki autoconfirmed user can't upload a new file version (see attachment
> > for error details), no problem instead with sysop rights. 
> > Is it related to this bug or it is a separate issue? Thanks (sorry for double
> > comment)
> > 
> 
> It is a different issue. I thought this restriction was in place before the new
> code as well, but please correct me if I'm wrong: Users can not upload an image
> which also exists under the same name as on Commons. Was this the previous
> situation as well?
> 

No, IMHO it is a bug. You are talking about "Reupload-shared" right but this is another issue.
I got this error for example when I try to upload new version of [[w:it:File:Pozzallo-Stemma.png]]. It does't exist any file on commons with this name! 
Comment 31 Simon 2009-09-18 23:16:06 UTC
Just to confirm I'm using en.wiki and have been getting the same error as reported in the first comment and by the user on it.wiki. I've just tried uploading a new image on commons too and get exactly the same error. 
Comment 32 Bryan Tong Minh 2009-09-19 09:03:23 UTC
reupload-shared problem fixed in r56631, waiting for shell to sync.
Comment 33 Tsun-En Chang 2009-09-20 07:17:26 UTC
I cannot upload file's new version, It still does'nt work.

Comment 34 François Alloing 2009-09-20 11:14:37 UTC
Same thing for me. On Commons I still cannot upload a new version of a file I created.
Comment 35 Dan Craggs 2009-09-20 21:19:46 UTC
We still don't have a fix for this? What's taking so long to correct this severe error? Are we just waiting for a backend sync again?
Comment 36 Bryan Tong Minh 2009-09-20 21:23:50 UTC
(In reply to comment #35)
> We still don't have a fix for this? What's taking so long to correct this
> severe error? Are we just waiting for a backend sync again?
> 

There is a fix, see #32, but we are waiting for somebody to sync this fix to Wikimedia servers.
Comment 37 Dan Craggs 2009-09-20 21:26:43 UTC
(In reply to comment #36)
> (In reply to comment #35)
> > We still don't have a fix for this? What's taking so long to correct this
> > severe error? Are we just waiting for a backend sync again?
> > 
> 
> There is a fix, see #32, but we are waiting for somebody to sync this fix to
> Wikimedia servers.
> 

So who can we prod to do this? ;-)
Comment 38 Platonides 2009-09-20 23:04:50 UTC
*** Bug 20750 has been marked as a duplicate of this bug. ***
Comment 39 Andrew Garrett 2009-09-21 12:13:56 UTC
Had a look, looks like it needs r56631, and possibly r56639 and r56640 to be merged.

Want to clarify this with Bryan before pushing live.
Comment 40 Tetromino 2009-09-21 19:11:55 UTC
Guys, are you planning to fix this any time soon?

This bug has been affecting most wikipedia and commons users (admins don't count, they are a tiny minority) for over 4 days. On ruwiki, I have seen users being forced to resort to ridiculous workarounds (like uploading a file under a new filename and marking the old one as {{Db-duplicate}}, and thus losing all revision history) to upload new versions of their files.
Comment 41 Roan Kattouw 2009-09-21 19:14:48 UTC
(In reply to comment #40)
> Guys, are you planning to fix this any time soon?
> 
> This bug has been affecting most wikipedia and commons users (admins don't
> count, they are a tiny minority) for over 4 days. On ruwiki, I have seen users
> being forced to resort to ridiculous workarounds (like uploading a file under a
> new filename and marking the old one as {{Db-duplicate}}, and thus losing all
> revision history) to upload new versions of their files.
> 

Yes, we're planning to fix this today (hopefully); Andrew's comment #39 illustrates this. The problems is that while we have a fix, we're looking for Bryan (the author of the fix) because we need him to clarify some things.
Comment 42 Andrew Garrett 2009-09-21 21:28:01 UTC
Fix deployed.
Comment 43 Pieter Kuiper 2009-09-25 18:04:18 UTC
The problem is not really resolved, http://toolserver.org/~magnus/flickr2commons.php still does not work. 
Comment 44 Brion Vibber 2009-09-25 18:06:53 UTC
Pieter, that'll be a separate issue; can you open a separate bug about it, and we'll poke Magnus to help debug it?
Comment 45 Pieter Kuiper 2009-09-25 22:11:04 UTC
Sorry, I am not at home here on bugzilla. I only registered an account last week to vote for this upload bug. Ok then, I will try to open a separate thing.
Comment 46 Platonides 2009-09-25 22:13:08 UTC
Pieter, that should probably be opened at jira https://jira.toolserver.org/ against the tool (then magnus could take it back against mediawiki).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links