Last modified: 2009-09-17 09:58:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T22671, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 20671 - wgRestrictionsEdit changed from array to object in JS variables served on each page: breaks a great many Javascripts
wgRestrictionsEdit changed from array to object in JS variables served on eac...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: Normal major with 1 vote (vote)
: ---
Assigned To: Andrew Garrett
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-09-17 08:25 UTC by Lupo
Modified: 2009-09-17 09:58 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Lupo 2009-09-17 08:25:44 UTC
r56032 breaks a great many Javascripts checking wgRestrictionEdit.

The following change

r1=55842&r2=56032&pathrev=56032">http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/Xml.php?r1=55842&r2=56032&pathrev=56032

makes that variable become an object (wgRestrictionEdit = {}) if the array is empty,
whereas previously it was an array (wgRestrictionEdit = []). Please revert ASAP (and push the revert to live wikis).

See also

http://commons.wikimedia.org/w/index.php?title=Commons:Village_pump#Problem_with_javascript_gadgets
Comment 1 eusebius 2009-09-17 09:31:15 UTC
I concur, we (Commons users, probably users on other projects as well) are much handicapped by this change in our everyday activities (which, for some, have become impossible).
Comment 2 Andrew Garrett 2009-09-17 09:58:34 UTC
Backwards-compatibility fix committed in r56497, deployed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links