Last modified: 2011-08-19 19:12:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T22656, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 20656 - crashes when content of <source> is too long
crashes when content of <source> is too long
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
SyntaxHighlight (GeSHi) (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-09-16 00:30 UTC by Lee Worden
Modified: 2011-08-19 19:12 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Lee Worden 2009-09-16 00:30:24 UTC
If there's a lot of source code in a <source> tag, the syntax highlighter crashes and the user gets a blank screen.  It would be better to fall back to a plain <pre> block instead of syntax highlighting in that case, or something.
Comment 1 Niklas Laxström 2009-09-16 06:44:32 UTC
Can you provide more details than just "blank page". Check the server logs or increase error reporting. If it is out of memory error I'm afraid there is nothing we can do. Which version of Geshi are you using?
Comment 2 Lee Worden 2009-09-17 04:06:08 UTC
MediaWiki 1.16alpha (i.e. trunk/phase3), at r56407, SyntaxHighlight_GeSHi Version 1.0.8.5 (r56284) according to Special:Version.

I see nothing relevant in the MW debug output.

I have in php.ini:
 error_reporting  =  E_ALL & ~E_NOTICE

Anyway, there seems to be more than one way to crash it with oversize inputs.
On a Special: page that uses the source tag I see:
 [Wed Sep 16 20:29:09 2009] [notice] child pid 25365 exit signal Segmentation fault (11)

and on a mainspace page that includes a source tag I see:
 [Wed Sep 16 20:42:56 2009] [error] [client 127.0.0.1] PHP Fatal error:  Allowed memory size of 52428800 bytes exhausted (tried to allocate 16 bytes) in /usr/src/mediawiki-extensions-trunk/SyntaxHighlight_GeSHi/geshi/geshi.php on line 3744

So at least some of the time it's an out of memory.  I'm going to consider imposing a file size limit and just using <pre> for bigger ones.
Comment 3 Bugmeister Bot 2011-08-19 19:12:42 UTC
Unassigning default assignments. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/54734

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links