Last modified: 2009-10-08 23:09:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T22612, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 20612 - "php deleteOldRevisions.php --delete" doesn´t work anymore
"php deleteOldRevisions.php --delete" doesn´t work anymore
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Maintenance scripts (Other open bugs)
1.16.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Chad H.
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-09-12 09:45 UTC by Kelson [Emmanuel Engelhart]
Modified: 2009-10-08 23:09 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch with --all option and a rewriting to allow to the script to be successful with big DB (3.59 KB, patch)
2009-09-14 16:37 UTC, Kelson [Emmanuel Engelhart]
Details

Description Kelson [Emmanuel Engelhart] 2009-09-12 09:45:50 UTC
I get:

Strict Standards: Creating default object from empty value in /var/www/kiwix/mirroring_tools/data/conf/default.php on line 88
Delete old revisions

Must pass at least 1 page_id

... seems not be possible anymore to remove *all* old revisions like indicated here:
http://marc.info/?l=mediawiki-l&m=116570740928550&w=2

The test on line 36 is responsible for that.

I suggest to remove it, at lest if the "--delete" arg is there.
Comment 1 Chad H. 2009-09-12 12:46:46 UTC
(In reply to comment #0)
> I get:
> 
> Strict Standards: Creating default object from empty value in
> /var/www/kiwix/mirroring_tools/data/conf/default.php on line 88
> Delete old revisions
> 

I'm not sure what that file is, but it's not Mediawiki

> Must pass at least 1 page_id
> 
> ... seems not be possible anymore to remove *all* old revisions like indicated
> here:
> http://marc.info/?l=mediawiki-l&m=116570740928550&w=2
> 
> The test on line 36 is responsible for that.
> 
> I suggest to remove it, at lest if the "--delete" arg is there.
> 

True, I noticed that when I was refactoring the script. Maybe an --all parameter would work.
Comment 2 Kelson [Emmanuel Engelhart] 2009-09-12 20:40:13 UTC
$ php ./deleteOldRevisions.php --all
Delete old revisions

Must pass at least 1 page_id
$

... same result.
Comment 3 Chad H. 2009-09-12 21:08:53 UTC
Well of course it won't work, it hasn't been written yet. I was saying that an --all parameter would be helpful.
Comment 4 Kelson [Emmanuel Engelhart] 2009-09-12 21:25:08 UTC
OK, I will do it... but IMO this is not really good to change the usage().
Comment 5 Kelson [Emmanuel Engelhart] 2009-09-14 16:37:38 UTC
Created attachment 6551 [details]
Patch with --all option and a rewriting to allow to the script to be successful with big DB
Comment 6 Kelson [Emmanuel Engelhart] 2009-09-14 17:24:33 UTC
Please take a look to my patch: it introduces the "--all" option.

But there is also a main rewriting of the script because with big databases,
the set of ids is too big to be accepted by the server and the script dies.

Now it works until the script calls purgeRedundantText() in Maintenance.php. At
this time the script dies for the same reason as deleteOldRevisions.php before
(too much ids) like following:

Il database ha restituito il seguente errore "1153: Got a packet bigger than
'max_allowed_packet' bytes (localhost)".

... but I prefer to propose a patch in an other bug report if you confirm the
issue.

Comment 7 Chad H. 2009-10-08 23:09:03 UTC
Fixed in r57540. Restored old behavior broken from maintenance-work branch merge. No page ids falls back to operating on all pages, as before. 

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links