Last modified: 2012-09-27 01:10:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T22550, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 20550 - Change "namespaces", "views" and "variants" portlet IDs to match existing convention.
Change "namespaces", "views" and "variants" portlet IDs to match existing con...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: Normal trivial with 1 vote (vote)
: ---
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-09-08 17:51 UTC by Ilmari Karonen
Modified: 2012-09-27 01:10 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ilmari Karonen 2009-09-08 17:51:04 UTC
In the MonoBook skin, the IDs for the various portlet <div>s consistently include a "p-" prefix.  The Vector skin inherits this naming for those portlets that also exist in MonoBook, but also adds three extra portlets with unprefixed IDs ("namespaces", "views" and "variants").  In order to maintain consistency, and to reduce the chances of accidental ID conflicts, these portlets should be renamed to "p-namespaces", "p-views" and "p-variants" respectively.
Comment 1 Trevor Parscal 2009-09-08 18:20:38 UTC
Fixed as of r56055

The reason they were like that is...

Originally none of the portlets had the "p-" prefix in Vector, because Vector puts things in different places and displays them in different ways, so scripts that modify Monobook a certain way running on Vector may result in unexpected behavior. but everyone complained that they wanted the IDs to match between skins so we changed the ones over that matched up with Monobook.

Given that "p-namespaces", "p-views" and "p-variants" do not exist in Monobook, it's really not a problem to go ahead and prefix those IDs with "p-"...

Hopefully this won't break a bunch of other stuff... I don't want to see bugs saying 'Change "p-namespaces" to "namespaces"' :)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links