Last modified: 2012-03-19 20:47:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T22524, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 20524 - Hideuser: Error when trying to block hidden user without hideuser right
Hideuser: Error when trying to block hidden user without hideuser right
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
User blocking (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: mac.med02
: patch, patch-need-review
Depends on:
Blocks: 14261 35331
  Show dependency treegraph
 
Reported: 2009-09-07 01:11 UTC by Church of emacs
Modified: 2012-03-19 20:47 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
attempted patch (1.52 KB, patch)
2009-10-01 19:41 UTC, mac.med02
Details
Message Refinement and Rename (2.21 KB, patch)
2009-10-02 03:20 UTC, mac.med02
Details
Final Fix (1.62 KB, patch)
2009-10-02 03:50 UTC, mac.med02
Details
Sorry again (1.31 KB, patch)
2009-10-04 01:50 UTC, mac.med02
Details
FIX (1.69 KB, patch)
2009-10-05 03:42 UTC, mac.med02
Details

Description Church of emacs 2009-09-07 01:11:09 UTC
Currently, it's a bit confusing for admins without hideuser right:
1. Admin sees EvilUsername
2. Oversight sees EvilUsername and is faster than the admin: He blocks EvilUsername with hideuser
3. Admin goes to Special:Block/EvilUsername. There is a warning, that EvilUser is "Already blocked", but the block log is empty.
4. Admin tries to block user and gets a strange error: "Error: could not submit form" and "<hookaborted>".

Expected behavior: Nice error message saying the admin is not allowed to change block settings as the user has been hidden.
Comment 1 mac.med02 2009-10-01 19:41:50 UTC
Created attachment 6611 [details]
attempted patch
Comment 2 mac.med02 2009-10-02 03:14:25 UTC
Note: Tests on the above patch succeeded on my local install of MediaWiki.
Comment 3 mac.med02 2009-10-02 03:20:52 UTC
Created attachment 6612 [details]
Message Refinement and Rename
Comment 4 mac.med02 2009-10-02 03:50:09 UTC
Created attachment 6613 [details]
Final Fix

Unrelated experimenal patch included in the last attachment. Sorry about all the emails.
Comment 5 mac.med02 2009-10-04 01:50:02 UTC
Created attachment 6618 [details]
Sorry again

hopefully this really is the last one
Comment 6 Church of emacs 2009-10-04 18:56:05 UTC
Don't forget to add new messages to maintenance/language/messages.inc, please :)
Also, try to use tabulator instead of spaces in Special:Blockip.php. It doesn't really look nice atm.
Comment 7 mac.med02 2009-10-05 02:28:19 UTC
I've tried two different editors to try and fix that problem (Notepad2 and PSPad). What would you recommend to deal with the issue? (Ie that pressing tab just creates spaces.
Comment 8 mac.med02 2009-10-05 03:42:18 UTC
Created attachment 6624 [details]
FIX

Hopefully this is the last one. Fixed messages.inc and changed spaces to tabs.
Comment 9 Church of emacs 2009-10-05 11:34:10 UTC
Done in r57375. Minor tweaks (MessagesXX.php uses spaces, not tabulators :))

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links