Last modified: 2014-02-12 23:38:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T22487, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 20487 - useless autopromotion at every request
useless autopromotion at every request
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
AbuseFilter (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: performance
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2009-09-03 14:16 UTC by Domas Mituzas
Modified: 2014-02-12 23:38 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Domas Mituzas 2009-09-03 14:16:35 UTC 
AbuseFilter seems to be running quite expensive (relatively) autopromotion code for every request, that involves RPC:

            4.3        > AbuseFilterHooks::onGetAutoPromoteGroups
           57.4         > memcached::get
0.000427    3.5         < memcached::get
0.000714    0.0        < AbuseFilterHooks::onGetAutoPromoteGroups

I suggest doing it only when 'expensive' checks are done (e.g. preview, save and editform).
Comment 1 Marcin Cieślak 2013-10-27 11:49:34 UTC 
that's the consequence of calling $user->getEffectiveGroups() everywhere, which checks implicit groups and autopromotions. Shall we extendend getEffectiveGroups with a $notABigDeal parameter?
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links