Last modified: 2009-09-03 18:08:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T22485, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 20485 - UsabilityInitiative combined/minified scripts are broken because of flawed combine.sh
UsabilityInitiative combined/minified scripts are broken because of flawed co...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UsabilityInitiative (Other open bugs)
unspecified
All All
: Normal critical with 1 vote (vote)
: ---
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-09-03 11:27 UTC by Mormegil
Modified: 2009-09-03 18:08 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Mormegil 2009-09-03 11:27:05 UTC
The combine.sh script which builds the combined/minified JS files is flawed. As a result, the UsabilityInitiative does not work at all currently if you set $wgUsabilityInitiativeResourceMode to 'combined' or leave it at the default 'minified'.

It is probably assumed the combined JS file will be made from the modules in the following order:

  jquery.async.js
  ...
  jquery.textSelection.js
> jquery.wikiEditor.js
> jquery.wikiEditor.dialogs.js
  jquery.wikiEditor.toc.js
  jquery.wikiEditor.toolbar.js

However, it is obviously not, because in the alphabetical order (used by “cat js/plugins/*.js”), “jquery.wikiEditor.js” comes only _after_ “jquery.wikiEditor.dialogs.js”. That means the resulting files tries to use $.wikiEditor in jquery.wikiEditor.dialogs.js before it is initialized in jquery.wikiEditor.js

If you do not want to list the files manually, you either need to sort them without the .js extension, or rename them, so that wikiEditor.js comes ahead of everything else.
Comment 1 Trevor Parscal 2009-09-03 18:08:29 UTC
Solved in r55781 by explicitly listing javascript files to be combined since order is important. We were previously just getting luck that alphabetical order was acceptable.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links