Last modified: 2014-11-17 09:21:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T22476, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 20476 - Split suppressrevision in two distinct permissions : the first one to oversight content, and the other one to review oversighted content
Split suppressrevision in two distinct permissions : the first one to oversig...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Revision deletion (Other open bugs)
1.24rc
All All
: Low major with 4 votes (vote)
: ---
Assigned To: Vogone
:
Depends on:
Blocks: revdel SWMT 20954
  Show dependency treegraph
 
Reported: 2009-09-02 19:35 UTC by Leinad
Modified: 2014-11-17 09:21 UTC (History)
17 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Leinad 2009-09-02 19:35:41 UTC
The same as in Extension:Oversight, please create in RevisionDelete permission to view hidden revisions from administrators (and other users). In Extension:Oversight this permission is called 'oversight'.

Reason:
In Wikiemdia projects stewards had permission 'suppressrevision' without permission 'deleterevision' - in this configuration stewards could view hidden revisions by oversighters. After enabling for stewards permission 'deleterevision', they can't have permission 'suppressrevision' due to transparency issues (stewards can't be permanent global oversighters).
Comment 1 Leinad 2009-09-19 19:51:59 UTC
After software update is even worse... stewards cannot view contribution of user, which was suppressed. This is problematic, because when steward suppress account, cannot revert edits.

Please fix bug as soon as possible and scap it.
Comment 2 Aaron Schulz 2009-09-22 22:01:45 UTC

*** This bug has been marked as a duplicate of bug 19199 ***
Comment 3 Leinad 2010-04-09 12:33:29 UTC
Hello again, after code update in Wikimedia there is still the same problem... ;/

Could you granularize permissions in suppresion tool? More details above.
Comment 4 Leinad 2010-05-10 14:17:54 UTC
Not only stewards needs this right, but also founder group, look at header of http://meta.wikimedia.org/wiki/Requests_for_comment/Remove_Founder_flag.
Comment 5 Leinad 2010-06-29 16:43:12 UTC
Hello, any progress? This bug waiting since September 2009 ;/
Comment 6 Leinad 2010-09-11 21:18:28 UTC
Just to clarify: currently stewards are permanent global oversighters.

Stewards have to have enabled permissions "deleterevision" and "suppressrevision", because stewards need access to view a contribution of users which was suppressed by using permission "hideuser" and for example check whether edit need be reverted.

So "suppressrevision" have to be divided on two permission:
1. suppressrevision-hide - hide revisions from administrators and other users (the same permission as "hiderevision" in Extension:Oversight),
2. suppressrevision-view - view a previously hidden revision by using new permisssion "suppressrevision-hide" and view an items hidden by using permission "hideuser".

Permission "1" will be assigned *only* for local oversight group (stewards can have oversight access on all wikis by granting themselves temporary local oversight access - look at Oversight policy http://meta.wikimedia.org/wiki/Oversight).

Permission "2" will be assigned for local oversight group and for global steward group.
Comment 7 Platonides 2010-09-12 22:42:38 UTC
Bug 19199 split deleterevision right into deleterevision (perform changes), deletedhistory (view history, like hidden user/comment) and deletedtext (view hidden text).

This bugs wants tp at least one split suppressrevision in two.
Comment 8 Leinad 2010-09-12 22:55:25 UTC
> Permission "2" will be assigned for local oversight group and for global
> steward group.

And for founder group.
Comment 9 Kudu 2011-09-01 20:09:59 UTC
The right should be split into suppressrevision, suppressedtext and suppressedhistory - it only makes sense.
Comment 10 Leinad 2012-02-28 20:52:19 UTC
Clickable link: r105432.
Comment 11 Leinad 2012-02-28 20:55:18 UTC
(In reply to comment #11)
> Clickable link: r105432.

Are you sure you wrote correct revision?
Comment 12 Quentinv57 2012-03-04 11:10:43 UTC
(changing the title to something more precise)
Comment 13 Mark A. Hershberger 2012-03-09 05:31:36 UTC
lowering priority to reflect reality
Comment 14 Gerrit Notification Bot 2014-06-12 22:24:23 UTC
Change 139277 had a related patch set uploaded by Vogone:
Split suppressrevision into two user rights

https://gerrit.wikimedia.org/r/139277
Comment 15 Jasper Deng 2014-07-18 06:10:41 UTC
(Requested by Legoktm here)

I feel like the patch is not what the bug is asking for. The bug asks for the actions themselves to be separated, not for one to imply the other.

I feel like one right implying another simply loses flexibility over having two mutually discrete rights - this is the case with CheckUser, for example.
Comment 16 Marius Hoch 2014-07-18 08:43:38 UTC
(In reply to Jasper Deng from comment #15)
> (Requested by Legoktm here)
> 
> I feel like the patch is not what the bug is asking for. The bug asks for
> the actions themselves to be separated, not for one to imply the other.
> 
> I feel like one right implying another simply loses flexibility over having
> two mutually discrete rights - this is the case with CheckUser, for example.

I don't think that two mutual exclusive rights make any sense over here. In the past we've introduced various rights that imply others and I don't see a problem with doing the same here. You should probably see the new right as a subset of the old one.
Comment 17 Happy-melon 2014-07-18 08:58:18 UTC
I agree that there's no reason for `supressrevision` not to be a superset of `viewsuppressed`.  Users who ended up with only the ability to suppress things, without the ability to see what they were doing, would have a very difficult time of things.  `suppressrevision` also incorporates the ability to *un*suppress content; how would a user exercise that if they couldn't see what had previously been suppressed?
Comment 18 Gerrit Notification Bot 2014-07-19 16:21:59 UTC
Change 139277 merged by SPQRobin:
Split "suppressrevision" into two user rights

https://gerrit.wikimedia.org/r/139277
Comment 19 Trijnstel 2014-08-12 15:44:12 UTC
One thing was forgotten, I think. The stewards are still able to oversight abuse log entries, which is also part of the oversight package. For example, I still can see the "adjust visibility" button on https://en.wikipedia.org/wiki/Special:AbuseLog - and I can click on it after which I can probably hide those entries if I would (won't test that now, but nothing has changed in the interface), while I'm definitely not an oversighter on enWP.
Comment 20 Vogone 2014-08-12 19:18:10 UTC
This is most likely due to stewards having "abusefilter-hide-log" assigned globally, but please correct me if I am wrong.
Comment 21 DerHexer 2014-08-12 19:22:48 UTC
(In reply to Vogone from comment #20)
> This is most likely due to stewards having "abusefilter-hide-log" assigned
> globally, but please correct me if I am wrong.

Thanks for pointing us on it. I've removed this right as well.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links