Last modified: 2012-02-10 00:27:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 20472 - AbuseFilter: disable "add at cursor" selection box when user can't edit filters
AbuseFilter: disable "add at cursor" selection box when user can't edit filters
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
AbuseFilter (Other open bugs)
unspecified
All All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-09-02 10:07 UTC by Gurch
Modified: 2012-02-10 00:27 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Proposed patch (2.52 KB, patch)
2010-11-10 15:33 UTC, EdoDodo
Details

Description Gurch 2009-09-02 10:07:40 UTC
At the moment, if you view a filter but can't edit it, you can use the "add at cursor" selection box to add stuff to the filter field, even though the field is disabled. You can't save it or anything, but it's still odd. That box should be disabled too.
Comment 1 EdoDodo 2010-11-10 15:33:50 UTC
Created attachment 7810 [details]
Proposed patch

I've attached a proposed patch that would hide the dropdown box and the check syntax button to users who cannot edit filters.
Comment 2 Andrew Garrett 2012-02-10 00:27:03 UTC
Patch applied, with modifications, in r111131.

Thanks for submitting a patch, and sorry that it took more than a year to be applied!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links