Last modified: 2009-09-30 00:42:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T22353, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 20353 - Patch: wfShellExec() malfunctioning on NT Build 7100
Patch: wfShellExec() malfunctioning on NT Build 7100
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Maintenance scripts (Other open bugs)
unspecified
All Windows Vista
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2009-08-22 13:36 UTC by Jimmy Xu
Modified: 2009-09-30 00:42 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Patch for GlobalFunctions.php (633 bytes, patch)
2009-08-22 13:36 UTC, Jimmy Xu 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Jimmy Xu 2009-08-22 13:36:02 UTC 
Created attachment 6482 [details]
Patch for GlobalFunctions.php

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

The original function provided a pair of extra quotes to the command after "cmd.exe /c", which will cause it fail to run. For example, when running [[mw:Extension:CodeReview]]::svnImport.php, it generates:

cmd.exe /c ""svn diff -r29:30 --non-interactive --trust-server-cert "/* REPO PATH */"""

And this will cause a "The filename, directory name, or volume label syntax is incorrect." error.

Maybe the patch will fix it. Best regards.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (MingW32)

iD8DBQFKj/QgRsiNGHPeu/URAsMuAJ4lySnYXXcPSuGUgwCROgnmNS48+QCfYs5yszJ9QWMzlJezFIuUlTUj/BA==qUgX
-----END PGP SIGNATURE-----
Comment 1 Chad H. 2009-08-22 15:31:57 UTC 
Cf bug 13518.
Comment 2 Chad H. 2009-09-21 19:50:42 UTC 
Patch applied in r56731
Comment 3 Brion Vibber 2009-09-29 23:35:58 UTC 
Exactly what behavior difference do you see between XP and Vista here? Where is the second pair of quotes being generated? MediaWiki only appears to produce one pair of quotes, so is the second one from PHP? If so, is this something to do with XP vs Vista or is it the version of PHP?
Comment 4 Chad H. 2009-09-30 00:42:26 UTC 
Cleaned up in r57093. Was fixed in PHP 5.3.0, not in a particular build of Windows.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links