Last modified: 2009-09-03 18:12:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T22349, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 20349 - wikieditor.css .ui-widget !important conflicts?
wikieditor.css .ui-widget !important conflicts?
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UsabilityInitiative (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2009-08-22 05:50 UTC by Michael Dale
Modified: 2009-09-03 18:12 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Michael Dale 2009-08-22 05:50:22 UTC 
In wikieditor.css you have:
.ui-widget {
	font-size: 13px !important;
}

This may not play predictiably well with other componets using the jquery-ui themeing system? 
a) is this the the best place for this?
b) could it target the toolbar stuff specifically?

Even if we agree all ui-widgets should be font-size 13 on our site things like !important on a base j-query.ui rule make it tricky to override if necessary.
Comment 1 Trevor Parscal 2009-09-03 18:12:20 UTC 
This was clearly not the best way to do this - it's been fixed by providing a complete jquery-ui theme call vector which matches vector. We need to create one for monobook as well and do some smart switching. But yeah, this has been removed already.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links