Last modified: 2011-03-13 18:06:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T22292, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 20292 - Implement input form support on strategy.wikimedia.org
Implement input form support on strategy.wikimedia.org
Status: RESOLVED WONTFIX
Product: Wikimedia
Classification: Unclassified
Site requests (Other open bugs)
unspecified
All All
: Lowest critical (vote)
: ---
Assigned To: Brion Vibber
http://strategy.wikimedia.org
: shell
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-08-17 20:35 UTC by Philippe Beaudette
Modified: 2011-03-13 18:06 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Philippe Beaudette 2009-08-17 20:35:14 UTC
Please install FormMailer and SimpleForms to the strategy.wikimedia.org wiki to support the major roll-out of the call for participation phase of strategic priority.  We are setting up an OTRS queue to manage the form mail.
Comment 1 Philippe Beaudette 2009-08-19 00:25:48 UTC
Moving priority to highest per meeting with Eugene Kim and Erik Moeller.  Show stopper for a major deployement.
Comment 2 Philippe Beaudette 2009-08-19 00:55:59 UTC
By the way - the workflow is:  User gets an email.  Goes to a page.  Enters their information and checks which task forces they're willing to be on.  A free text field for CV.  Then hits send, which sends it to an OTRS queue.

If there are better extensions, do that instead.
Comment 3 Brion Vibber 2009-08-19 05:59:48 UTC
Neither of these extensions appear to be in our subversion repository, so they'll need to be reviewed and committed.

http://www.mediawiki.org/wiki/Extension:FormMailer
http://www.mediawiki.org/wiki/Extension:Simple_Forms

Assigning to myself for initial review...
Comment 4 Brion Vibber 2009-08-19 06:15:20 UTC
http://www.organicdesign.co.nz/Extension:FormMailer.php

$wgExtensionFunctions[] = 'wfSetupFormMailer';

This appears to be the actual form processing function, with several *huge* problems:
* there's no check that the form was POSTed, so you can be spammed by an <img>
* there's no particular location to which the form needs to be posted
* there's no protection against cross-site requests, much less form submissions

This needs to be redone using a clear entry point such as a Special page, with a check for POSTing. Preferably include an edittoken check to protect against cross-site form submissions.


$_SERVER['REMOTE_ADDR']

This will always show one of our proxies. Needs to use wfGetIP()


foreach ($wgRequest->getValues() as $k => $v) if (!in_array($k, $wgFormMailerDontSend)) {

Looks it really should just stick to things with the form prefix and not touch anything else... all sorts of misc vars might turn up in your form that don't belong in there.


$wgSiteNotice .= "<div class='usermessage'>".($err ? $err : $message)."</div>";

This is utterly broken. :) The sitenotice is definitely the wrong place to put success/error output.


More generally, it lacks any way to specify multiple different forms, as well as not using the localization framework for its UI messages.
Comment 5 Brion Vibber 2009-08-19 06:16:13 UTC
Simple Forms is listed as obsolete and unmaintained; definitely not installing that. :)

Aran, what's the replacement that you would recommend?
Comment 6 Philippe Beaudette 2009-08-19 06:17:11 UTC
I'm not wedded to those extensions; but need similar functionality... forms with multiple input types (picklist, check box, text enter), and mailing to OTRS.
Comment 7 MZMcBride 2009-08-19 06:37:42 UTC
http://www.mediawiki.org/wiki/Extension:Form may be a contender. It interacts using MediaWiki pages and wiki templates and has a number of options for various input types (checkbox, radio, select, etc.).

It's written to support posting new wiki pages, but may be adaptable to outputting to e-mail instead.
Comment 8 Aran 2009-08-19 21:35:50 UTC
Sorry we don't really have a replacement for SimpleForms, we've just been using Raw html restricted to the Form NS
Comment 9 Philippe Beaudette 2009-08-19 21:38:59 UTC
updated Bug summary;

We will need some form of form input that generates mail.  Would Extension:Form be an option?  
Comment 10 Marcin Cieślak 2009-08-19 22:12:28 UTC
Before we really dive into form bureaucracy:

1) Is this targeted at the general public or at the editing community?
2) If this is general public, why not just use a wiki page supported by the Javascript form like this one:

http://pl.wikipedia.org/w/index.php?title=MediaWiki:Wikibugs.js

People could create short profiles, willing to describe what they really feel to write about themselves, 
not full CVs that would need to be protected.

I don't understand why can't use a simpler, less bureaucratic concept?


Comment 11 Philippe Beaudette 2009-08-19 22:50:43 UTC
The form is targeted at all users, not just editors.  Most of these people will not want their email addresses published to a wiki page.  In addition, there will be potentially thousands of responses - edit conflicts abound.  Some of them may want to include information about work history that particularly qualifies them for a task force; they may wish for that information to not be public.
Comment 12 Philippe Beaudette 2009-09-12 05:32:02 UTC
no longer necessary

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links