Last modified: 2010-05-15 15:33:25 UTC
The skin system includes site wide user defined JavaScript by including the message <Skinname>.js into the output (e.g. the content of the <Monobook.js> message is included in the output for Monobook users). For user defined skins this message does not exist in most cases. Besides having the administrators or the skin developers define that message (which is both error prone), there are two solutions to avoid the bug: * Define an empty message for each skin in the Language class (or in the MessageCache?) * Don't include the message into output, if it has only the fallback message content (and is not defined)
Created attachment 483 [details] patch for CVS The attached patch implements the second solution described above: When generating the user JS output it checks if the message is defined and avoids the message output if not defined.
Created attachment 484 [details] patch for REL14
Um, I think I entirely forgot the JavaScript error message in the problem report. The generated JavaScript file looks like this: /* generated javascript */var skin = 'reduced'; var stylepath = '/development/skins';/* MediaWiki:Reduced */ <Reduced.js> The problem can be seen in the third line, where the default message text occurs, which is no valid JavaScript.
Thanks! Patch committed to CVS HEAD and REL1_4.
