Last modified: 2011-04-30 01:20:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T22239, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 20239 - broken html tag on "Files" tab of preferences
broken html tag on "Files" tab of preferences
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.15.x
All All
: Normal trivial (vote)
: ---
Assigned To: Rupinder
http://tmbw.net/wiki/Special:Preferen...
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2009-08-14 14:11 UTC by Brad Will (tmbw.net)
Modified: 2011-04-30 01:20 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
A screenshot of the problem on my site. (99.84 KB, image/jpeg)
2009-08-14 14:11 UTC, Brad Will (tmbw.net) 		Details
Proposed Patch (570 bytes, patch)
2009-08-15 18:49 UTC, Rupinder 		Details
Better to use the old text (880 bytes, patch)
2009-08-16 12:46 UTC, Rupinder 		Details
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Description Brad Will (tmbw.net) 2009-08-14 14:11:17 UTC 
Created attachment 6459 [details]
A screenshot of the problem on my site.

In 1.15.1, on the "files" tab of preferences, this is the text i see:

Image size limit:<br />''(for file description pages)''

The html tag shouldn't be showing as text.
Comment 1 Rupinder 2009-08-15 18:49:56 UTC 
Created attachment 6465 [details]
Proposed Patch

The Xml::label function uses Xml::element which further employs the use of htmlspecialchars. htmlspecialchars converted the '<' and '>' tags to &lt and &gt respectively.
Comment 2 Niklas Laxström 2009-08-15 21:04:52 UTC 
(In reply to comment #1)
> Created an attachment (id=6465) [details]
> Proposed Patch

Just revert the affected message to the previous version (or remove the <br />), no need to touch code.
Comment 3 Rupinder 2009-08-16 12:46:21 UTC 
Created attachment 6466 [details]
Better to use the old text

Reverting to the text in Revision 48780
Comment 4 Alexandre Emsenhuber [IAlex] 2009-08-25 21:22:47 UTC 
Fixed in r55587.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links