Last modified: 2009-11-16 21:16:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T22221, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 20221 - Edit boxes lose changes on back/forward
Edit boxes lose changes on back/forward
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UsabilityInitiative (Other open bugs)
unspecified
PC All
: Normal enhancement with 1 vote (vote)
: ---
Assigned To: Trevor Parscal
:
: 20277 20294 21537 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-08-13 15:38 UTC by RSpeer
Modified: 2009-11-16 21:16 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description RSpeer 2009-08-13 15:38:52 UTC
Contrary to the way most edit boxes work in modern browsers, the edit boxes in Vector lose all my changes when I hit the back or forward button. This was especially annoying when I was hitting "back" to try to salvage my text from an edit conflict, instead of hunting for it in the big huge slow box. What I had written was simply gone.
Comment 1 Sam Reed (reedy) 2009-08-13 15:51:22 UTC
Works fine on Chrome.

FYI, this is really a browser bug
Comment 2 Roan Kattouw 2009-08-13 15:52:00 UTC
This is a bug in Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=285730

We're hoping to deploy a workaround soon.
Comment 3 Splarka 2009-08-14 04:20:03 UTC
(In reply to comment #2)
> This is a bug in Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=285730

It is arguable whether it is a bug or "feature". This has been the case going back to Firebird and older Mozilla. If you mess with a form's DOM (I think the simplest case, is to change element names, or add/remove elements), it is no longer the same form, so why should it be treated as such? You'd have the same lack of textarea-memory when creating a dyamic form from scratch in javascript after document load. 

IMHO, the best solution is to not mess with the form using javascript (or, show/hide existing elements, or if you are needing to be dynamically  creating elements, create them *outside* the <form>, then it works fine), then it simply works in Firefox. Remember, Vector is for usability, and if this is "broke" in every current version of Firefox, then it isn't usable.
Comment 4 Roan Kattouw 2009-08-14 08:16:17 UTC
(In reply to comment #3)
> (In reply to comment #2)
> > This is a bug in Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=285730
> 
> It is arguable whether it is a bug or "feature". This has been the case going
> back to Firebird and older Mozilla. If you mess with a form's DOM (I think the
> simplest case, is to change element names, or add/remove elements), it is no
> longer the same form, so why should it be treated as such?
It's only triggered by adding form fields above the affected ones, because Mozilla stupidly uses field indexes instead of field names to restore stuff, (which means it'll try to restore the textarea's content into the <select> for headers, if I interpret the bug correctly). This also means fields above the first dynamically added one do get restored correctly, which in turn means Mozilla does seem to think that it's the same form. Also, in Chrome this just works.

> You'd have the same
> lack of textarea-memory when creating a dyamic form from scratch in javascript
> after document load. 
> 
> IMHO, the best solution is to not mess with the form using javascript (or,
> show/hide existing elements, or if you are needing to be dynamically  creating
> elements, create them *outside* the <form>, then it works fine), then it simply
> works in Firefox. Remember, Vector is for usability, and if this is "broke" in
> every current version of Firefox, then it isn't usable.
> 

Like I said, we are working on a workaround, which involves replacing the dynamically created <select> by something else. I'll ask Trevor what the status of that is.
Comment 5 Roan Kattouw 2009-08-16 11:22:44 UTC
*** Bug 20277 has been marked as a duplicate of this bug. ***
Comment 6 conti 2009-08-16 11:44:13 UTC
The same problem appears in Opera (9.64), so it's not just Firefox. For what it's worth, I never had this problem with the old skin.
Comment 7 Derk-Jan Hartman 2009-08-16 11:58:07 UTC
and Safari 4.
Comment 8 Roan Kattouw 2009-08-17 21:28:05 UTC
*** Bug 20294 has been marked as a duplicate of this bug. ***
Comment 9 Roan Kattouw 2009-08-18 18:15:37 UTC
(In reply to comment #4)
> Like I said, we are working on a workaround, which involves replacing the
> dynamically created <select> by something else. I'll ask Trevor what the status
> of that is.
> 

This was done in r55247, I'll try to get it deployed.
Comment 10 Roan Kattouw 2009-08-18 19:42:31 UTC
(In reply to comment #9)
> (In reply to comment #4)
> > Like I said, we are working on a workaround, which involves replacing the
> > dynamically created <select> by something else. I'll ask Trevor what the status
> > of that is.
> > 
> 
> This was done in r55247, I'll try to get it deployed.
> 
Fix is live.
Comment 11 conti 2009-08-19 09:42:05 UTC
(In reply to comment #10)
> Fix is live.
> 

I still have the same problem with both Opera and Firefox.
Comment 12 Derk-Jan Hartman 2009-08-19 10:53:05 UTC
Fixed in Safari 4 it seems.
Comment 13 Roan Kattouw 2009-11-16 21:16:36 UTC
*** Bug 21537 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links