Last modified: 2009-09-23 20:56:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T22218, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 20218 - "Cite this page" toolbox link does not have a title attribute
"Cite this page" toolbox link does not have a title attribute
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Cite (Other open bugs)
unspecified
All All
: Normal trivial (vote)
: ---
Assigned To: Robin Krahl
: easy, patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-08-13 12:44 UTC by Derk-Jan Hartman
Modified: 2009-09-23 20:56 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
adds the missing "title"-tag and changes the way how to add the patch (3.12 KB, patch)
2009-09-22 16:39 UTC, Robin Krahl
Details
improved version of the previous posted patch (4.12 KB, patch)
2009-09-22 20:29 UTC, Robin Krahl
Details
third version. simplifies the 2nd version. (4.12 KB, patch)
2009-09-22 21:04 UTC, Robin Krahl
Details
The real 3rd version (3.88 KB, patch)
2009-09-22 21:10 UTC, Robin Krahl
Details
Minor tweaks, merging wfSpecialCiteToolboxCite to wfSpecialCiteToolbox (3.57 KB, patch)
2009-09-22 21:38 UTC, Church of emacs
Details
adds title tag to toolbar link, simplifies the code (3.58 KB, patch)
2009-09-23 19:51 UTC, Robin Krahl
Details

Description Derk-Jan Hartman 2009-08-13 12:44:07 UTC
I'm not sure if Special:Cite and this link are actually added by the Cite extension, but i don't think it's part of the core software either. If Cite is the incorrect extension, please reclassify this.
Comment 1 Robin Krahl 2009-09-22 16:38:05 UTC
I tried to write a patch. At this occasion, I changed the way how to add the link to the toolbar. Maybe a more experienced coder can take a look at it. Thanks.

Comment 2 Robin Krahl 2009-09-22 16:39:39 UTC
Created attachment 6570 [details]
adds the missing "title"-tag and changes the way how to add the patch
Comment 3 Robin Krahl 2009-09-22 20:29:51 UTC
Created attachment 6572 [details]
improved version of the previous posted patch

improved the previous posted patch. basically, it does the same, but in a better way ;)
Comment 4 Robin Krahl 2009-09-22 21:04:03 UTC
Created attachment 6573 [details]
third version. simplifies the 2nd version.

This patch does basically the same as the two patches already posted. But: The code is less, and functions we don’t need are deleted.

We don’t have to check whether the special page “cite” exists because we required the extension containing the page (it’s defined in the same extension).
Comment 5 Robin Krahl 2009-09-22 21:10:33 UTC
Created attachment 6574 [details]
The real 3rd version

I’m so sorry I selected the wrong file -- this is what I pronounced as Patch Nr. 3 ^^
Comment 6 Church of emacs 2009-09-22 21:38:54 UTC
Created attachment 6575 [details]
Minor tweaks, merging wfSpecialCiteToolboxCite to wfSpecialCiteToolbox

Note that the patches introduced a small bug:

On non-existing pages, the Cite-Link is displayed. @Ireas: please fix it :)
Comment 7 Robin Krahl 2009-09-23 19:51:25 UTC
Created attachment 6577 [details]
adds title tag to toolbar link, simplifies the code

This should really fix all issues ;)
Comment 8 Church of emacs 2009-09-23 20:56:06 UTC
Done in r56832 and r56836.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links