Last modified: 2012-09-27 01:10:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T22175, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 20175 - Tabs of current deployment are 1 pixel off at the bottom.
Tabs of current deployment are 1 pixel off at the bottom.
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: Normal blocker (vote)
: ---
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-08-11 11:28 UTC by Derk-Jan Hartman
Modified: 2012-09-27 01:10 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Derk-Jan Hartman 2009-08-11 11:28:20 UTC
Safari 4, clear cache, the tabs all have an extra pixel of height or offset in the current deployment version of the code. Selected tabs now have a 1px border at the bottom, and not selected tabs have a thicker bottom border.
Comment 1 Trevor Parscal 2009-08-11 19:25:31 UTC
This was a regression of sorts from r54601 which changed from pt to em text size in the body rule - which distorted following em calculations, fixed in r54806.
Comment 2 Brion Vibber 2009-08-19 00:57:24 UTC
Trevor, can you please test the comment in http://www.mediawiki.org/wiki/Special:Code/MediaWiki/54806#c3564 re: affect of px on browser zoom in IE prior to 8? (I'm fairly sure this isn't true on semi-modern browsers like IE 6 and applied to really, *really* old browsers only, but don't hvae an IE6 on me to test right now.)

More importantly, we seem to have regressed on the browser font size specification issues -- this sticks us back to an author-specified default, overriding the user's font size settings in their browser.
Comment 3 Brion Vibber 2009-08-19 00:58:25 UTC
Upping priority as the changes made have caused accessibility regressions.
Comment 4 Trevor Parscal 2009-08-19 18:28:48 UTC
Changed the font sizing scheme in r55333 which resolves this issue completely, including now respecting IE 5 - 7 user font sizing.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links