Last modified: 2014-09-01 15:09:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 2013 - Vector: Avoid specifying line-height using "em" (vertical squishing for headers/large text)
Vector: Avoid specifying line-height using "em" (vertical squishing for heade...
Status: REOPENED
Product: MediaWiki skins
Classification: Unclassified
Vector (Other open bugs)
unspecified
All All
: Low trivial
: ---
Assigned To: Rahul Maliakkal
:
: 9162 60523 (view as bug list)
Depends on:
Blocks: css
  Show dependency treegraph
 
Reported: 2005-04-29 00:49 UTC by Karsten Sperling
Modified: 2014-09-01 15:09 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Karsten Sperling 2005-04-29 00:49:06 UTC
Monobook makes frequent use of line-height specifications using the unit "em".
While these lengths _are_ font-size-relative, which is good, the computed value,
and not the relative value is inherited by child elements, which is bad.

The problem becomes apparent when a child node uses a different font-size. E.g.
many boxes on Wikipedia use font-size:80%. However, because the computed value
of line-height is inherited, the line-height stays unchanged (i.e. too large).

The solution is to use plain number line-heights, i.e. "1.5" instead of "1.5em".
That way, the line-height will properly scale when the font-size is changed.

Here's the relevant section from the CSS2 spec:
http://www.w3.org/TR/REC-CSS2/visudet.html#propdef-line-height

  Values for this property have the following meanings:
  [...]
  <length>
      The box height is set to this length. Negative values are illegal. 
  <number>
      The computed value of the property is this number multiplied by the
element's font
      size. Negative values are illegal. However, the number, not the computed
value, is
      inherited.
Comment 1 Aryeh Gregor (not reading bugmail, please e-mail directly) 2006-10-13 07:07:14 UTC
Agreed, makes no sense to inherit computed value.  Fixed in r16988.
Comment 2 Mormegil 2006-11-06 16:25:38 UTC
Reopening, obviously reverted in r17047.
Comment 3 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-03-04 01:53:05 UTC
*** Bug 9162 has been marked as a duplicate of this bug. ***
Comment 4 Rahul Maliakkal 2013-03-21 20:06:56 UTC
Gerrit change #55126
Comment 5 Gerrit Notification Bot 2013-04-22 16:09:29 UTC
https://gerrit.wikimedia.org/r/55126 (Gerrit Change Id73860df38a9d284bb4a8f279c1b525f99fc1150) | change ABANDONED [by Krinkle]
Comment 6 Derk-Jan Hartman 2013-12-09 13:39:28 UTC
Related and also abandoned: https://gerrit.wikimedia.org/r/27043/
Comment 7 Bartosz Dziewoński 2014-03-27 21:39:21 UTC
*** Bug 60523 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links