Last modified: 2010-01-02 20:26:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T22115, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 20115 - Special:UserLogin <title>,<h1> should check $wgUser->isAllowed( 'createaccount' )
Special:UserLogin <title>,<h1> should check $wgUser->isAllowed( 'createaccoun...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
User login and signup (Other open bugs)
1.16.x
All All
: Normal trivial (vote)
: ---
Assigned To: Karun
http://abj.jidanni.org/index.php?titl...
: easy, patch, patch-reviewed
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2009-08-07 19:52 UTC by Dan Jacobson
Modified: 2010-01-02 20:26 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Patch to fix bug 20115 (1.53 KB, patch)
2010-01-02 09:57 UTC, Karun 		Details
Patch that fixes bug 20115 (1.51 KB, patch)
2010-01-02 10:02 UTC, Karun 		Details
Patch to fix bug (3.73 KB, patch)
2010-01-02 10:27 UTC, Karun 		Details
Patch for bug 20115 with unrelated changes removed and in svn diff format (1.81 KB, patch)
2010-01-02 20:06 UTC, Karun 		Details
Show Obsolete (3) Add an attachment (proposed patch, testcase, etc.)

Description Dan Jacobson 2009-08-07 19:52:41 UTC 
We see that setting
$wgGroupPermissions['*']['createaccount']=false
1. Nicely leaves only 'Log in' in the upper right corner of the screen.
2. Nicely leaves only the 'Log in' box in the middle of the screen.

However, the <title> and <h1> still mention both "Log in / create account"!

The use might wonder "hey, where can I create the account it mentions?"

(Indeed, you might even go the whole hog and make Special:SpecialPages list it differently too.)
Comment 1 Dan Jacobson 2009-08-07 19:53:58 UTC 
s/The use might/The user might/
Comment 2 Dan Jacobson 2009-08-21 10:03:29 UTC 
> (Indeed, you might even go the whole hog and make Special:SpecialPages list it
> differently too.)
Which is in fact a _different_ bug 19186.
Comment 3 Karun 2010-01-02 09:57:48 UTC 
Created attachment 6916 [details]
Patch to fix bug 20115

I have started a patch to create two separate messages userlogin and userlogincreate. I attach it. With the patch, when the permission to create accounts is set to true, it does not show the correct message.
I am not sure why this is the case. Could someone review it and advise the cause?
Comment 4 Karun 2010-01-02 10:02:27 UTC 
Created attachment 6917 [details]
Patch that fixes bug 20115

In relation to my previous comment, I found that I was not using user permissions correctly. This patch fixes the bug with the creation of a new message userlogincreate and modification to userlogin.
Comment 5 Max Semenik 2010-01-02 10:13:14 UTC 
Looks good, two comments: use svn diff instead of diff --git, and add the newly created message to maintenance/language/messages.inc.
Comment 6 Karun 2010-01-02 10:27:46 UTC 
Created attachment 6918 [details]
Patch to fix bug

Ive added it to the messages.inc file and used svn diff.
Comment 7 Roan Kattouw 2010-01-02 11:54:43 UTC 
(In reply to comment #6)
> Created an attachment (id=6918) [details]
> Patch to fix bug
> 
> Ive added it to the messages.inc file and used svn diff.
> 

There seem to be some unrelated changes in your diff (two in MessagesEn.php, and the $wgProxyWhitelist change).
Comment 8 Karun 2010-01-02 20:06:27 UTC 
Created attachment 6920 [details]
Patch for bug 20115 with unrelated changes removed and in svn diff format

Ive removed the unrelated changes, and the patch only includes the changes for this bug, and is in svn diff format. 

Please review.
Thanks
Comment 9 Roan Kattouw 2010-01-02 20:22:37 UTC 
Modified patch committed in r60563.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links