Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T22073, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 20073 - CodeReview does not properly detect a "preview" comment

Summary:	CodeReview does not properly detect a "preview" comment

Status: RESOLVED FIXED Product: MediaWiki extensions Classification: Unclassified Component: CodeReview (Other open bugs) Version: unspecified Hardware: All All Importance: Normal enhancement (vote) Target Milestone: --- Assigned To: Aaron Schulz URL: Whiteboard: Keywords: patch, patch-need-review Depends on: Blocks:   Show dependency tree / graph		Reported: 2009-08-05 04:57 UTC by Nakon Modified: 2009-08-25 03:30 UTC (History) CC List: 1 user (show) innocentkiller See Also: Web browser: --- Mobile Platform: --- Assignee Huggle Beta Tester: ---

Attachments changes the check from null to 0 (423 bytes, patch) 2009-08-05 04:57 UTC, Nakon Details Add an attachment (proposed patch, testcase, etc.)

Description Nakon 2009-08-05 04:57:29 UTC Created attachment 6421 [details] changes the check from null to 0 The script returns a comment ID of 0 on preview which is not what the code expects. Comment 1 Aaron Schulz 2009-08-25 03:30:19 UTC Fixed in r55564