Last modified: 2009-10-08 17:51:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T22064, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 20064 - XML schema not updated, current MediaWiki dumps are not valid
XML schema not updated, current MediaWiki dumps are not valid
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Export/Import (Other open bugs)
unspecified
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Tomasz Finc
http://www.validome.org/xml/validate/...
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-08-04 13:23 UTC by Mormegil
Modified: 2009-10-08 17:51 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Updates to export.xsd (3.62 KB, patch)
2009-08-04 13:23 UTC, Mormegil
Details

Description Mormegil 2009-08-04 13:23:58 UTC
Created attachment 6418 [details]
Updates to export.xsd

The XML schema for exports (docs/export-0.3.xsd) has not been updated to include the <redirect/> flag, added in r53271.

Which means the current dumps (on http://download.wikimedia.org/backup-index.html) are not valid.

And, XmlDumpWriter in Export.php already notes “FIXME: upgrade to 0.4 when updated XSD is ready, for the revision deletion bits”, since the revision deletion support in export files has not been noted in the schema, too. (Since r13224, yikes!)

And finally, the (unfinished?) log exports from r40968 are also missing in the XSD.

See the attachment – it is a unified diff from export-0.3.xsd to export-0.4.xsd, I am not sure, what the policy on those versions should be, so I hope this format is understandable (change the versioning as suitable).
Comment 1 Chad H. 2009-08-04 18:57:45 UTC
Cf bug 13750. Completely different issue, but also calls for an update to the schema.

Might be worth getting that committed and bundling all these schema changes into v0.4.
Comment 2 Andrew Garrett 2009-08-04 19:03:04 UTC
Note that there are some LiquidThreads bits that will soon be also added to the XML schema.
Comment 3 Brion Vibber 2009-08-05 16:41:08 UTC
Assigning to Tomasz.
Comment 4 Tomasz Finc 2009-08-05 18:41:23 UTC
Updates from Mormegil added on r54472. 
Comment 5 Mormegil 2009-08-05 21:02:07 UTC
If the updates have been added as export-0.4.xsd, changing XmlDumpWriter::schemaVersion to return "0.4" (according to the TODO note there) would probably be wise. (See includes/Export.php, line 351.)
Comment 6 Tomasz Finc 2009-08-05 21:09:13 UTC
We'll certainly do that but there are a couple of changes pending that i'm going to wait on before officially bumping the version. Look for it to happen by the end of the week.
Comment 7 Tomasz Finc 2009-09-09 19:22:39 UTC
Picking this up again. Checked in new examples with r56108. Now time to verify the xsd against an actual parser.
Comment 8 Tomasz Finc 2009-09-09 21:53:29 UTC
Made a couple more tweaks to export-0.4.xsd and now it passes $dom->schemaValidate().
Comment 9 Tomasz Finc 2009-09-18 22:47:16 UTC
Version bump. Waiting on deployment. http://www.mediawiki.org/wiki/Special:Code/MediaWiki/56612
Comment 10 Brion Vibber 2009-10-08 17:39:55 UTC
Poke
Comment 11 Tomasz Finc 2009-10-08 17:51:15 UTC
and as of Wed Oct 7 00:35:32 2009

http://svn.wikimedia.org/viewvc/mediawiki?view=rev&revision=57448

the change is on the deployment branch. It's also made it's way onto the cluster.

Resolving.


Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links