Last modified: 2009-08-24 18:07:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T21966, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 19966 - MediaWiki:License used for two different purposes: should use two different messages
MediaWiki:License used for two different purposes: should use two different m...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: Normal enhancement with 2 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-07-28 07:04 UTC by Lupo
Modified: 2009-08-24 18:07 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Lupo 2009-07-28 07:04:17 UTC
Currently, [[MediaWiki:License]] is being used

1. on the upload form as the label of the license drop-down menu

2. on file description pages as a section header for the licensing information when the user did select an entry from said drop-down menu

The two uses are semantically different, but SpecialUpload.php uses the same message. This causes problems: most (but not all) languages have it set to include a trailing ":", as for all other labels on the upload form. However, when used as a section title, it shouldn't have that trailing colon.

That could be solved easily by using two different messages, e.g. MediaWiki:License_label and MediaWiki:License_heading.

Without such a split, we'll either have a missing colon on the upload form, or an extra unwanted colon in the section header. (Note that just defining MediaWiki:License without the colon and making SpecialUpload.php always add the colon after the labels is not an option (and would be a hack anyway): some languages use a blank before the colon (French: "License :", but English: "License:"), and some don't use colons after the labels at all.)

The initial values for the new messages should be set as
- MediaWiki:License_label = MediaWiki:License
- MediaWiki:License_header = (MediaWiki:License).replace (/\s*:$/, "")

An additional benefit of this split is that it makes it possible to define the two texts differently, e.g. "License:" for the label and "Licensing" for the header, if so desired.
Comment 1 Alexandre Emsenhuber [IAlex] 2009-08-24 18:07:31 UTC
Fixed in r55558.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links