Last modified: 2009-07-28 08:47:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T21953, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 19953 - Add link to CodeReview to mediawiki-cvs e-mails
Add link to CodeReview to mediawiki-cvs e-mails
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Subversion (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Brion Vibber
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2009-07-27 10:44 UTC by Chad H.
Modified: 2009-07-28 08:47 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Chad H. 2009-07-27 10:44:45 UTC 
I actively read mediawiki-cvs; it's my main way of keeping an eye on commits. It would be pretty easy I think to add a link to code review. Right now I have to copy+paste the rev #.
Comment 1 Brion Vibber 2009-07-27 17:45:21 UTC 
Ought to be possible with a suitable tweak to the commit scripts...
Comment 2 Brion Vibber 2009-07-27 17:59:32 UTC 
Ought to be possible with a suitable tweak to the commit scripts...

Checking man page for svnnotify...

         -U --revision-url URL        Include links to specified Revision URL.

This doesn't do what I expected; -U seems to want a viewcvs/viewvc base URL:
-U "http://www.mediawiki.org/wiki/Special:Code/MediaWiki/$2"

ends up with output like:

Revision: 53816
         
http://www.mediawiki.org/wiki/Special:Code/MediaWiki/53816/revision/?rev=53816&view=rev


Trying with header text instead:

  --header "http://www.mediawiki.org/wiki/Special:Code/MediaWiki/$2"

Ok, this is looking good. :D

http://www.mediawiki.org/wiki/Special:Code/MediaWiki/53818

Revision: 53818
Author:   werdna
Date:     2009-07-27 17:57:51 +0000 (Mon, 27 Jul 2009)


at eg http://lists.wikimedia.org/pipermail/mediawiki-cvs/2009-July/074877.html
Comment 3 Niklas Laxström 2009-07-28 08:47:41 UTC 
I just noticed this and it is great! One of those small things that annoy us a little every day. Thanks.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links