Last modified: 2014-02-12 23:45:36 UTC
Someone requested that when you click on the search box, the text be highlighted instead of the cursor going to the end of the word.
We could add the following, but it would need to be tested on the iPhone. $("#searchField").click(function() { $(this).focus() $(this).select() })
Is this already implemented? If so, we can close this bug.
No it isn't implemented.
Quick question since you marked this as "easy" - could you point to the file(s) the newbie would need to fix? Basically all the stylesheets in the extensions/MobileFrontend/stylesheets/ directory?
This needs to be implemented in application.js, however it can't (or shouldn't, really) use jQuery, but instead use native JavaScript.
Created attachment 9983 [details] text gets higlighted as soon as the focus is brought back to the text box It works fine with Mozilla Firefox and Internet Explorer 9, but it doesnt seem to work in google chrome.
Created attachment 9984 [details] Solved problem of the text be highlighted instead of the cursor going to the end of the word solved the problem of the text be highlighted instead of the cursor going to the end of the word check out but its only work in IE and in Firefox. thanks to akhshay.
Hi, Ashwini and Akshay. Thank you for the patches! As you can see in https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker#Submit_your_changes in order to signal to the development community that this Bugzilla bug report has a patch associated with it that needs review, you should add the keywords patch and need-review I've now done this for you, but in the future, please do it yourself every time you add a patch in Bugzilla. Thanks. Have you run the automated test suites against your patch(es)? That's a very good way to find problems. https://www.mediawiki.org/wiki/Manual:PHP_unit_testing and https://www.mediawiki.org/wiki/Manual:PHP_unit_testing/Installing_PHPUnit will help you. If you have any trouble, please find us in #mediawiki on Freenode and ask!
(In reply to comment #8) > Hi, Ashwini and Akshay. Thank you for the patches! As you can see in > > https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker#Submit_your_changes > > in order to signal to the development community that this Bugzilla bug report > has a patch associated with it that needs review, you should add the keywords > > patch > > and > > need-review Unfortunately, they were not able to add the keywords. I assume this was a limitation of the user permissions for newly created accounts?
(In reply to comment #9) > Unfortunately, they were not able to add the keywords. I assume this was a > limitation of the user permissions for newly created accounts? Yes, argh. I've added the ability to edit keywords to Akshay's and Ashwini's Bugzilla accounts and will have to consider whether we should modify this lockdown to balance between between security and access/usability.
akshay chugh and ashwini - thanks for your patches! I've applied them in r112103
I've seen evidence of a user use her microphone to enter text into the search box. Then when she clicks on the search box to correct the mistake in the first word the entire text highlights. She then proceeds by clearing the entire text and typing from scratch. This evidence suggests we //shouldn't// highlight the search result.
