Last modified: 2012-10-29 16:39:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T21905, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 19905 - Sysop undeletion removes revision deletion restrictions
Sysop undeletion removes revision deletion restrictions
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Revision deletion (Other open bugs)
1.16.x
All All
: Normal major with 1 vote (vote)
: ---
Assigned To: Aaron Schulz
http://nl.wikipedia.org/w/index.php?t...
:
Depends on:
Blocks: SWMT
  Show dependency treegraph
 
Reported: 2009-07-23 22:02 UTC by Mike.lifeguard
Modified: 2012-10-29 16:39 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Mike.lifeguard 2009-07-23 22:02:20 UTC
Here, some revision deletion (suppression) was done, then the page was undeleted, which removed all those restrictions, and they were placed again. If a sysop can't modify the visibility on an individual revision, they can't be allowed to sidetrack it by nuking all restrictions by undeleting the whole page.
Comment 1 DerHexer 2009-07-23 23:06:26 UTC
Afaics that case just happens when it's the only revision of the entire article. Just when then that single revision gets deleted, hidden and restored it will lose all restrictions. It might not happen quite often, but happened and is not unrealistic.

Kind regards
DerHexer
Comment 2 Aaron Schulz 2009-07-24 07:07:47 UTC
(In reply to comment #1)
> Afaics that case just happens when it's the only revision of the entire
> article. Just when then that single revision gets deleted, hidden and restored
> it will lose all restrictions. It might not happen quite often, but happened
> and is not unrealistic.
> Kind regards
> DerHexer

Trying to restore a one-rev suppressed page just gives me a permission error if I don't have the rights.

If a user does have the oversight permissions, restoring a page will always clear restrictions on the very top revision. Otherwise, things would break or it would have to just give a restoration error and do nothing.
Comment 3 DerHexer 2009-07-24 10:59:19 UTC
Hmm, Wutsje (a nl.wp sysop who's not a steward/oversight) was able to restore it. I've tested it on test.wp recently: If a sysop restores just hidden revisions of an entirely deleted page, one revision at least gets unhidden (because of the reason you mentioned: a public article cannot just contain hidden revisions).
Comment 4 Aaron Schulz 2009-07-24 11:00:59 UTC
Was the edit suppressed or was just regular revisiondelete used? 
Comment 5 Aaron Schulz 2009-07-24 11:10:52 UTC
(In reply to comment #4)
> Was the edit suppressed or was just regular revisiondelete used? 
> 

Nevermind...I see the issue, I was testing the wrong code branch
Comment 6 Aaron Schulz 2009-07-24 12:22:04 UTC
Fixed in r53715
Comment 7 Aaron Schulz 2009-07-28 11:23:26 UTC
Already synced

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links