Last modified: 2012-07-12 06:54:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T21852, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 19852 - Wrong parameter in gadgets loading
Wrong parameter in gadgets loading
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Gadgets (Other open bugs)
unspecified
All All
: Highest blocker with 2 votes (vote)
: ---
Assigned To: Daniel Kinzler
:
: 20396 (view as bug list)
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2009-07-21 04:25 UTC by Liangent
Modified: 2012-07-12 06:54 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Liangent 2009-07-21 04:25:11 UTC 
In the HTML, it's using

<script type="text/javascript" src="/w/index.php?title=MediaWiki:Gadget-mycommon.js&amp;action=raw&amp;ctype=text/javascript?230"></script>

to load gadgets now. But "?230 is completely wrong. It means the value of ctype parameter is "text/javascript?230". It stops gadgets from being loaded. Firefox says:

The resource from this URL is not text: http://zh.wikipedia.org/w/index.php?title=MediaWiki:Gadget-mycommon.js&action=raw&ctype=text/javascript?230

Remove "?230" or change it to "&230" please.
Comment 1 Chad H. 2009-07-21 13:47:19 UTC 
I'm not really sure we should be appending $wgStyleVersion to Gadget URLs. They need to be purged when updated, yes, but $wgStyleVersion doesn't update on Gadget changes, making it basically useless.

Suggest removal, not changing it to &nnn.
Comment 2 Liangent 2009-07-21 15:48:59 UTC 
Maybe we can append revision id (oldid) of that gadget page to the end of url.
Comment 3 Mike.lifeguard 2009-08-03 03:06:22 UTC 
r53376 seems to fix this.
Comment 4 Alexandre Emsenhuber [IAlex] 2009-08-25 19:19:44 UTC 
*** Bug 20396 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links