Last modified: 2009-07-28 00:52:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T21849, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 19849 - X-Vary-Options header should be configurable, not sent to users
X-Vary-Options header should be configurable, not sent to users
Status: CLOSED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Brion Vibber
: easy, patch
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-07-21 02:33 UTC by Laurence 'GreenReaper' Parry
Modified: 2009-07-28 00:52 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Require $wgUseXVO = true; to send X-Vary-Options header (1.54 KB, patch)
2009-07-21 03:19 UTC, Laurence 'GreenReaper' Parry
Details

Description Laurence 'GreenReaper' Parry 2009-07-21 02:33:58 UTC
MediaWiki sends a custom X-Vary-Options header on responses. The reason for doing so is described here:
http://www.mail-archive.com/squid-dev@squid-cache.org/msg07066.html

An example:
X-Vary-Options: Accept-Encoding;list-contains=gzip,Cookie;string-contains=ruToken;string-contains=ruLoggedOut;string-contains=ru_session\r\n

This header helps patched caches. However for those sites which don't have that patch applied, or who don't use Squid at all - i.e. pretty much everyone outside Wikimedia - this feature just adds around 137 uncompressed bytes of useless padding per request.

This header should be optional, and off by default, unless/until this patch is accepted upstream in Squid.

FWIW, I also feel this header should also be stripped out from Wikimedia responses going to end-users (==if there is no Via: header in the request), otherwise you're needlessly sending them ~260 uncompressed bytes per request:
X-Vary-Options: Accept-Encoding;list-contains=gzip,Cookie;string-contains=enwikiToken;string-contains=enwikiLoggedOut;string-contains=enwiki_session;string-contains=centralauth_Token;string-contains=centralauth_Session;string-contains=centralauth_LoggedOut

This would presumably involve changing the Squid patch itself.
Comment 1 Laurence 'GreenReaper' Parry 2009-07-21 03:19:37 UTC
Created attachment 6375 [details]
Require $wgUseXVO = true; to send X-Vary-Options header
Comment 2 Brion Vibber 2009-07-24 19:59:56 UTC
Assinging to self for review...
Comment 3 Brion Vibber 2009-07-24 20:07:22 UTC
Committed in r53725

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links