Last modified: 2012-09-27 01:10:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T21801, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 19801 - Vector adds wikiprintable.css but like monobook does not require it.
Vector adds wikiprintable.css but like monobook does not require it.
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2009-07-17 23:36 UTC by Derk-Jan Hartman
Modified: 2012-09-27 01:10 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Derk-Jan Hartman 2009-07-17 23:36:24 UTC 
The source contains:
<link rel="stylesheet" href="/skins-1.5/common/wikiprintable.css?230" type="text/css" media="print" />

I'm not really sure why, because VectorSkin extends SkinTemplate, which has: 

public function commonPrintStylesheet() {
                return false;
}

And according to Skin:
         * Skins that have their own
         * print stylesheet should override this and return false.  (This is an
         * ugly hack to get Monobook to play nicely with
         * OutputPage::headElement().)
Comment 1 Dan Jacobson 2009-07-19 02:19:36 UTC 
Got to go, but in case any of these are related to ink printers, I wonder why a person who never pressed a print button or owns a printer needs them to come down the phone lines in the first place.
Comment 2 Trevor Parscal 2009-07-21 22:06:05 UTC 
This is fixed in head (r52864), awaiting deployment.
Comment 3 Derk-Jan Hartman 2009-08-20 10:59:37 UTC 
The bug is still present in current deployment. It also causes the license to be hidden if a user chooses print when using the vector skin, which is somewhat of a problem.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links