Last modified: 2009-07-17 16:49:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T21783, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 19783 - The names of CSS classes should have underscores instead of spaces
The names of CSS classes should have underscores instead of spaces
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
AbuseFilter (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Andrew Garrett
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2009-07-17 09:56 UTC by Ruslan
Modified: 2009-07-17 16:49 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Ruslan 2009-07-17 09:56:33 UTC 
See, for instance

http://en.wikipedia.org/w/index.php?title=Kanwar_Pal_Singh_Gill&action=history

Here each tag (i.e. Tag: References removed) is wrapped in <span class="mw-tag-marker mw-tag-marker-references removed>. But 'mw-tag-marker-references' and 'removed' are separated by a space, which means that there are actually two classes 'mw-tag-marker-references' and 'removed'. On the other hand each tagged entry in the history is wrapped in <li class="mw-tag-references_removed">, which correctly has an underscore symbol. The same problem appears in the recent changes. See for example

http://en.wikipedia.org/w/index.php?title=Special:RecentChanges&tagfilter=references+removed

Can spaces in class names used in <span> tags be replaced with underscores?
Comment 1 Andrew Garrett 2009-07-17 10:05:27 UTC 
Works fine for me.

<li class="mw-tag-references_removed">
Comment 2 Andrew Garrett 2009-07-17 10:08:01 UTC 
Never mind, I was looking at a later part, which I fixed in r53391.
Comment 3 Ruslan 2009-07-17 16:49:15 UTC 
Thank you, Andrew.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links