Last modified: 2014-02-12 23:38:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T21716, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 19716 - show only changed lines when viewing the change of an abuse filter in the abuse filter history
show only changed lines when viewing the change of an abuse filter in the abu...
Status: REOPENED
Product: MediaWiki extensions
Classification: Unclassified
AbuseFilter (Other open bugs)
unspecified
All All
: Low enhancement with 2 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-07-14 18:18 UTC by Umherirrender
Modified: 2014-02-12 23:38 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Umherirrender 2009-07-14 18:18:56 UTC
There is no need to show an item in a diff, when there is no change to it. Please show only items with a difference, so the user can easilier catch all necessary information. Thanks.
Comment 1 Roan Kattouw 2009-07-14 18:37:12 UTC
Diffs show a few lines before and a few lines after as context. This is supposed to be a feature.
Comment 2 Roan Kattouw 2009-07-14 18:38:31 UTC
Oh this is an AbuseFilter bug, I'm sorry. Reopening so Andrew can do with it what he wants.
Comment 3 Beau 2011-08-20 20:12:12 UTC
*** Bug 20310 has been marked as a duplicate of this bug. ***
Comment 4 Beau 2011-08-20 20:19:45 UTC
*** Bug 20851 has been marked as a duplicate of this bug. ***
Comment 5 Beau 2011-08-20 20:30:58 UTC
*** Bug 26433 has been marked as a duplicate of this bug. ***
Comment 6 Kleiner 2011-10-16 03:33:10 UTC
The problem related on bug 20851 has been seen by me a couple of days ago. As I'm not sure if that bug is really a duplicate from this bug, I guess I should report it here too:

Please, compare the value of added_lines and removed_lines variables with the
actual diff on this case:

* Actual diff:
https://pt.wikipedia.org/w/index.php?title=Alexis_Texas&diff=27267727&oldid=27110744
* Abuse log: https://pt.wikipedia.org/wiki/Especial:AbuseLog/864451

What I've found particulary odd was that this problem occured only with some
edits, and mostly with bots edits, although at time the code wasn't filtering
by user group (I've even added a user group condition, thinking at first this
could be the problem, though it not seems the case now).

If bug 20851 is indeed a duplicate of this bug, I'm sorry.
Comment 7 Liangent 2012-07-07 19:58:42 UTC
Maybe it's related to line feeds. Let them be visible below:

Old text:

Line 1\n
Line 2

New text:

Line 1\n
Line 2\n
Line 3

So "
Line 2
" is removed and "
Line 2\n
Line 3
" is added. We may want to add trailing line feeds when calculating diff variables.
Comment 8 Liangent 2012-07-07 20:01:57 UTC
(In reply to comment #6)
> * Abuse log: https://pt.wikipedia.org/wiki/Especial:AbuseLog/864451

It's private and I cannot see it.
Comment 9 Liangent 2012-07-07 20:02:50 UTC
Also may be some CRLF & LF issue? but this can affect the whole article...
Comment 10 Umherirrender 2012-07-08 15:22:05 UTC
(In reply to comment #9)
> Also may be some CRLF & LF issue? but this can affect the whole article...

That problem is fixed with bug 20310

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links