Last modified: 2011-03-13 18:06:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T21671, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 19671 - Try using git-svn for CodeReview on MediaWiki.org to make viewing diffs faster
Try using git-svn for CodeReview on MediaWiki.org to make viewing diffs faster
Status: RESOLVED WONTFIX
Product: MediaWiki extensions
Classification: Unclassified
CodeReview (Other open bugs)
unspecified
All All
: Lowest enhancement (vote)
: ---
Assigned To: Aaron Schulz
http://johan.kiviniemi.name/blag/svn-...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-07-12 03:59 UTC by Ævar Arnfjörð Bjarmason
Modified: 2011-03-13 18:06 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ævar Arnfjörð Bjarmason 2009-07-12 03:59:37 UTC
Every time I look at a revision diff on mediawiki.org there's a little spinning globe reminding me that something is fetching that diff over the network.

If you cloned the MediaWiki repository with git-svn and did git svn rebase on every commit you could do must faster diffs, e.g.:

$ time svn diff -r 53124:53125 > /dev/null

real    0m7.538s
user    0m0.020s
sys     0m0.012s

$ git diff $(git svn find-rev r53124)  $(git svn find-rev r53125) > /dev/null

real    0m0.814s
user    0m0.436s
sys     0m0.368s
Comment 1 Roan Kattouw 2009-07-12 08:12:47 UTC
These diffs are cached AFAIK, so I don't think it would cause that much of a performance improvement.
Comment 2 Chad H. 2009-07-22 01:40:38 UTC
Marking this WONTFIX. Diffs are only generated on first load. They're afterwards stored in the database, and cached on top of that. Even after a cache expiry, we're only retrieving this from a slave, so the savings would be minimal on first load--at best.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links