Last modified: 2010-10-31 22:05:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T21633, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 19633 - Scale up thumbnails of small SVG
Scale up thumbnails of small SVG
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
unspecified
All All
: Normal normal with 2 votes (vote)
: ---
Assigned To: Ariel T. Glenn
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-07-10 09:49 UTC by xeddvok7bd7464n2
Modified: 2010-10-31 22:05 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Possible new check (1.01 KB, patch)
2010-05-18 20:02 UTC, Derk-Jan Hartman
Details

Description xeddvok7bd7464n2 2009-07-10 09:49:21 UTC
Small SVG file with a nominal size less than 180 px will not be enlarged when using them as thumb images. Their size remains small although this are scalable files and you can download rendered PNG images with bigger sizes (see http://commons.wikimedia.org/wiki/File:CH-Hinweissignal-Ausfahrtstafel_(3).svg).
Comment 1 xeddvok7bd7464n2 2009-07-10 09:52:12 UTC
See http://commons.wikimedia.org/wiki/User:Debianux/SVG-Bug
Comment 2 Brion Vibber 2009-08-03 16:53:54 UTC
Assigning SVG bugs to Ariel -- need a cleanup pass to see what's fixed up by a librsvg upgrade, what can be resolved with fixes to our font configuration, what can be fixed on our end, and what still needs to be pushed upstream.
Comment 3 Guillaume Paumier 2009-12-31 23:09:45 UTC
We scale up thumbnails of small SVGs in <gallery>s, so it makes sense to scale them up when used with |thumb as well.
Comment 4 Derk-Jan Hartman 2010-05-18 19:47:42 UTC
Linker.php makeImageLink2()

When no explicit width is set, width is initiated as the full image size (which is the nominal image size for an SVG). Then in case of thumbnails, the thumbsize is retrieved from the preferences, but that thumbsize is ONLY used, if ( $prefWidth < $hp['width'] ). Because in the case of small nominal SVG sizes, prefwidth will always be larger, the default thumbnail size is never used.

The same is true for small bitmap images such as File:External_link_icon.png
Comment 5 Derk-Jan Hartman 2010-05-18 20:02:50 UTC
Created attachment 7384 [details]
Possible new check

We could choose to always 'upscale' material that is vector based.....

The patch shows such a check, but requires implementation of isVectorized().
Comment 6 Derk-Jan Hartman 2010-10-31 14:43:11 UTC
hmm, this is totally the wrong patch btw. It seems that I have lost that one. :(
Comment 7 Derk-Jan Hartman 2010-10-31 22:05:39 UTC
Fixed with r75748 and r75749

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links