Last modified: 2014-02-27 19:44:18 UTC
Created attachment 6302 [details] Add navigator.accentColorName to KDE detection in wikibits.js When <!DOCTYPE html> is used (yes, I know . . .), the is_khtml compatibility variable in wikibits.js is activated by Google Chrome. This misdetection results in the KHTML fix stylesheet being applied, including this rule: #column-content { margin-left: 0; } Unfortunately this prevents the portlets from floating on the left; instead, they appear on the left but beneath the page content. http://www.webreference.com/programming/javascript/sniffing/2.html suggested that the presence of navigator.accentColorName could be used to distinguish between Konquerer and Safari (or rather KHTML and Webkit, hence including Chrome). I added this to is_khtml, the stylesheet was no longer loaded, and the problem disappeared.
HTML5, assigning to Aryeh.
I already deleted the extra stylesheet entirely in r53141 (do you think it does anything useful?). I wish I had known about this earlier so I didn't have to panic like I did. :)
Not confident this is fixed as the revision is marked fixme. Though I would not be opposed to deleting it entirely if it can be confirmed that most KHTML users will not be affected as a result (or there are none :-).
The commit has not been reverted, so I'm re-resolving. I believe I've adequately addressed werdna's fixme. I've noted the bug number on the code review page, so anyone reverting it should reopen this. Even if there are KHTML users, a variable that encompasses five years of their browser's history is unlikely to be useful for targeting actual bugs. Whatever bugs it was used for back in the dawn of time are almost certainly long since fixed. If they aren't, a workaround can be re-added with appropriate version number checks, rather than assuming that all KHTML past, present, and future will have exactly the same bugs.
