Last modified: 2009-07-04 01:37:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T21509, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 19509 - can't upload to file called '0'
can't upload to file called '0'
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Uploading (Other open bugs)
1.16.x
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy, patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-07-04 01:28 UTC by Lee Worden
Modified: 2009-07-04 01:37 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
patch for SpecialUpload.php (revision 52760) (1.30 KB, patch)
2009-07-04 01:28 UTC, Lee Worden
Details

Description Lee Worden 2009-07-04 01:28:02 UTC
Created attachment 6297 [details]
patch for SpecialUpload.php (revision 52760)

When the destination filename in Special:Upload is set to '0', it's considered to be unset, and the file is uploaded, using the filename of the source file as the destination filename.  If the destination filename is '1', however, the wiki warns that the destination doesn't have an extension.  This is because $this->mDesiredDestName is used as a boolean several times in SpecialUpload.php, where it would be more correct to test ($this->mDesiredDestName != ''), which flags both null and '' as empty values, but not '0'.  This is a minor bug all right, but there it is.  It's present in the newupload branch too.
Comment 1 Chad H. 2009-07-04 01:37:39 UTC
Fixed in r52761

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links