Last modified: 2010-05-15 15:33:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T3949, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 1949 - Skin.php coding typo in line 1506


Summary:	Skin.php coding typo in line 1506

Status:	CLOSED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	General/Unknown (Other open bugs)
Version:	1.4.x
Hardware:	PC Linux

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:	patch

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2005-04-22 18:23 UTC by luzi82
Modified:	2010-05-15 15:33 UTC (History)
CC List:	0 users

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
patch to solve typo in Skin.php line 1506 (71 bytes, patch) 2005-04-22 18:24 UTC, luzi82	Details
Add an attachment (proposed patch, testcase, etc.)

Description luzi82 2005-04-22 18:23:02 UTC

it is found in 1.4.2 actually, not 1.4.0, (do not have the option).

in Skin.php, there is a function "makeKnownLinkObj", the second "wfProfileIn"
seems to be "wfProfileOut".

for patch:

1506c1506
<                       wfProfileOut( $fname );
---
>                       wfProfileIn( $fname );

Comment 1 luzi82 2005-04-22 18:24:51 UTC

Created attachment 448 [details]
patch to solve typo in Skin.php line 1506

Comment 2 Brion Vibber 2005-04-22 20:45:01 UTC

Fix applied in CVS HEAD and REL1_4, thanks for the catch.

For future reference, try to make your diffs with the -u option as this provides 
some context and makes it easier to a) see what the patch does from reading it 
and b) automatically merge the patch when the file has been changed.

The order of arguments should also be original, _then_ new file; this diff seems 
to be reversed.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links