Last modified: 2010-05-15 15:33:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 1949 - Skin.php coding typo in line 1506
Skin.php coding typo in line 1506
Status: CLOSED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.4.x
PC Linux
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-04-22 18:23 UTC by luzi82
Modified: 2010-05-15 15:33 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
patch to solve typo in Skin.php line 1506 (71 bytes, patch)
2005-04-22 18:24 UTC, luzi82
Details

Description luzi82 2005-04-22 18:23:02 UTC
it is found in 1.4.2 actually, not 1.4.0, (do not have the option).

in Skin.php, there is a function "makeKnownLinkObj", the second "wfProfileIn"
seems to be "wfProfileOut".

for patch:

1506c1506
<                       wfProfileOut( $fname );
---
>                       wfProfileIn( $fname );
Comment 1 luzi82 2005-04-22 18:24:51 UTC
Created attachment 448 [details]
patch to solve typo in Skin.php line 1506
Comment 2 Brion Vibber 2005-04-22 20:45:01 UTC
Fix applied in CVS HEAD and REL1_4, thanks for the catch.

For future reference, try to make your diffs with the -u option as this provides 
some context and makes it easier to a) see what the patch does from reading it 
and b) automatically merge the patch when the file has been changed.

The order of arguments should also be original, _then_ new file; this diff seems 
to be reversed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links