Last modified: 2011-10-26 09:25:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T21437, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 19437 - centralnotice.js should be served compressed and from bits.
centralnotice.js should be served compressed and from bits.
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CentralNotice (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Ryan Kaldari
: fundraising
: 24530 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-06-30 04:56 UTC by Laurence 'GreenReaper' Parry
Modified: 2011-10-26 09:25 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Laurence 'GreenReaper' Parry 2009-06-30 04:56:16 UTC
The file http://upload.wikimedia.org/centralnotice/wikipedia/en/centralnotice.js does not appear to be HTTP compressed by the server. Doing so would save ~1.4kb, or ~65% of its size. It would probably fit into one or two packets rather than the three that it currently occupies.
Comment 1 Brion Vibber 2009-07-13 18:25:22 UTC
Fred, do we know how to appropriately config JWS for this on ms1?
Comment 2 Max Semenik 2010-05-29 17:06:12 UTC
And it also should be served from bits.wikimedia.org, which became available later.
Comment 3 Umherirrender 2010-07-30 18:14:07 UTC
see also bug 24594
Comment 4 Derk-Jan Hartman 2010-07-30 20:59:48 UTC
*** Bug 24530 has been marked as a duplicate of this bug. ***
Comment 5 Mark A. Hershberger 2011-03-06 21:27:12 UTC
Giving half of Fred's old bugs to Ashar since I trust him to get it done or reassign if he doesn't have time.
Comment 6 Krinkle 2011-03-07 09:06:58 UTC
It should either be part of the extension, in which case it can be loaded from wgExtensionAssetsPath:

http://bits.wikimedia.org/w/extensions-1.17/CentralNotice/centralnotice.js

Or, if WMF specific, it could be stored locally and defined as a module in CommonSettings.php and loaded (so that it's cached and minifed, and served from bits.wikimedia.org/wiki.domain/load.php, the same way other skins and extensions styles/scripts are loaded.


The file centralnotice.js does exist in SVN but does not mach the one at:
  http://upload.wikimedia.org/centralnotice/wikipedia/en/centralnotice.js

Is the one from upload.wm.o still in use ? perhaps this has been fixed already...
Comment 7 Roan Kattouw 2011-03-07 17:57:52 UTC
Or just RL-ify CentralNotice?
Comment 8 Krinkle 2011-03-08 21:45:42 UTC
(In reply to comment #7)
> Or just RL-ify CentralNotice?

it would have to be part of the extension first (ie. in the extensions' directory) or an on-wiki page as script source (ie. MediaWiki:Centralnotice.js)
Comment 9 Ryan Kaldari 2011-10-07 04:08:36 UTC
http://upload.wikimedia.org/centralnotice/wikipedia/en/centralnotice.js hasn't been used in years. The entire root level centralnotice directory was deleted from trunk a long time ago. How do we remove it from upload.wikimedia.org?

There is a centralnotice.js file within the CentralNotice extension, which is served from ResourceLoader.
Comment 10 Ryan Kaldari 2011-10-07 04:12:26 UTC
I'm going to go ahead and resolve this as fixed. If anyone wants to open a separate bug about deleting the old http://upload.wikimedia.org/centralnotice/ directory, that would be fine by me.
Comment 11 Roan Kattouw 2011-10-25 13:49:00 UTC
(In reply to comment #9)
> http://upload.wikimedia.org/centralnotice/wikipedia/en/centralnotice.js hasn't
> been used in years. The entire root level centralnotice directory was deleted
> from trunk a long time ago. How do we remove it from upload.wikimedia.org?
> 
This stuff lives in /mnt/upload6/centralnotice . If it's really not used any more, you can just shell into fenari and kill it. However, there seems to be ton of things in there, lots of different centralnotice.js files in a 2-level (wiki/language, it seems) directory structure and images here and there.
Comment 12 Ryan Kaldari 2011-10-25 17:22:30 UTC
Yeah, those are all the generated javascript files for all the wikis as of the last time they were generated (probably about 2 years ago). All of that stuff is dynamic now. I imagine the images were for various banners. Now we host the images on meta and commons, which is less secure, but more practical.
Comment 13 Tomasz Finc 2011-10-25 17:26:33 UTC
Just delete all those files. We don't need them.
Comment 14 Arthur Richards 2011-10-25 17:53:21 UTC
I've archived the contents of /mnt/upload6/centralnotice. 

I can't, however, remove the directory as I do not have sufficient permissions to remove everything (many things are owned by apache and in the apache group and I don't have r00t). Roan, can you take care of that?
Comment 15 Roan Kattouw 2011-10-26 09:25:52 UTC
(In reply to comment #14)
> I've archived the contents of /mnt/upload6/centralnotice. 
> 
> I can't, however, remove the directory as I do not have sufficient permissions
> to remove everything (many things are owned by apache and in the apache group
> and I don't have r00t). Roan, can you take care of that?
I'll delete it once you're awake and on IRC, so we can restore it quickly if anything bad happens.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links