Last modified: 2010-07-04 17:19:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T21324, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 19324 - AbuseFilter handles merged edit conflicts wrongly
AbuseFilter handles merged edit conflicts wrongly
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
AbuseFilter (Other open bugs)
unspecified
All All
: High minor (vote)
: ---
Assigned To: Andrew Garrett
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-06-21 11:30 UTC by od_mishehu
Modified: 2010-07-04 17:19 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description od_mishehu 2009-06-21 11:30:30 UTC
See, for example, http://en.wikipedia.org/w/index.php?title=Special:AbuseLog&details=593181 corresponds to http://en.wikipedia.org/w/index.php?title=Howcast&diff=296900469&oldid=296900306, and not http://en.wikipedia.org/w/index.php?title=Howcast&diff=296900469&oldid=296900379. This only happens when the times of the edits are close to each other; it was suggested that the reason for this is edit conflicts.
Comment 2 Gurch 2009-06-28 16:44:02 UTC
(In reply to comment #1)
> Looks like the automatic resolving of edit conflicts is what is causing this.

Ugh... the abuse filter comes before even *that*? I've said here before that it should be the *final* step before an edit is saved... at the moment we get all manner of strange situations where the abuse filter is triggered where it should not be (esp. on edits that would have failed anyway, like rollbacks to non-top edits), of which this is only one.

Comment 3 Andrew Garrett 2009-07-03 14:10:32 UTC
Updated summary.

(In reply to comment #2)
> (In reply to comment #1)
> > Looks like the automatic resolving of edit conflicts is what is causing this.
> 
> Ugh... the abuse filter comes before even *that*?

No, it comes after that. That's the problem.

Comment 4 Andrew Garrett 2009-07-16 17:07:58 UTC
(batch change)

Minor bugs that nevertheless need looking into
Comment 5 Andrew Garrett 2009-07-31 10:06:01 UTC
Looking at the code and testing locally indicates that this is resolved with the current SVN version. Must have been unintentionally fixed at some point.
Comment 6 RockMFR 2009-08-01 00:27:00 UTC
This was fixed by r52740, based on my testing. Would this be an expected side-effect of that change?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links