Last modified: 2009-06-17 20:34:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T21264, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 19264 - flaggedrevs-backlog message shown when there is no backlog
flaggedrevs-backlog message shown when there is no backlog
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Aaron Schulz
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-06-17 17:33 UTC by Gurch
Modified: 2009-06-17 20:34 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Gurch 2009-06-17 17:33:12 UTC
The FlaggedRevs extension adds a message in a big red box to the top of watchlists stating "There is currently a backlog of pending edits to reviewed pages. Your attention is needed!" It does this regardless of whether there are actually any pending edits or not. On small wikis, this makes it rather annoying.

The extension should be changed either to show this message only when there actually are unreviewed revisions, or not to show it at all, and let individual wikis add permanent watchlist messages if they think they are needed.
Comment 1 Gurch 2009-06-17 18:38:12 UTC
Hm. Had a look at the code, and there is logic there to do this, but because estimateRowCount returns 1 when there are 0 rows, on a wiki with less than 50 pages the message is always shown, hence why I couldn't make it go away on my test wiki. I guess that's not too much of a problem.
Comment 2 Aaron Schulz 2009-06-17 20:00:23 UTC
If the estimate is low, then the brute query can be run, which would avoid this.
Comment 3 Aaron Schulz 2009-06-17 20:34:05 UTC
Fixed in r52072

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links