Last modified: 2010-07-04 17:19:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T21261, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 19261 - Do not strip off addition in parenthesis in signature
Do not strip off addition in parenthesis in signature
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: High minor (vote)
: ---
Assigned To: Andrew Garrett
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-06-17 15:42 UTC by Christian Thiele
Modified: 2010-07-04 17:19 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Christian Thiele 2009-06-17 15:42:12 UTC
For some days now, in signatures all additions in parenthesis are removed. E.g. if you are user "Test (Addition)", your signature will be "Test". This is bad, because you can't see the real username. If someone wants his addition removed, he can do this in his preferences, but this isn't a good standard behavior.
Comment 1 Andrew Garrett 2009-06-17 18:10:19 UTC
Unable to reproduce on enwiki. It's probably a use of the pipe trick in an overridden system message on whatever wiki you're trying it on.
Comment 2 hanns-ulrich 2009-06-22 06:45:06 UTC
This happens on de.wikipedia.org. Before last week, everything was fine with "Test (Addition)". Only since a few days ago, the "transformation" mentioned above has been happening.
Comment 3 P.Copp 2009-06-22 12:30:50 UTC
(In reply to comment #1)
> Unable to reproduce on enwiki. It's probably a use of the pipe trick in an
> overridden system message on whatever wiki you're trying it on.
> 

I was able to reproduce it on enwiki by opening [[Special:Preferences]] and saving them without changes with a test account. I guess, somehow the signature gets saved as NULL or empty string.
Comment 4 Brion Vibber 2009-06-23 01:41:33 UTC
[[MediaWiki:Signature]] default is "[[{{ns:user}}:$1|$2]]"

If the sig gets saved empty, and then gets actually used, you'll end up with:

[[User:Test (Addition)|]]

which will pipe-trick expand to:

[[User:Test (Addition)|Test]]

If the sig field is empty we should end up using the username instead for the $2 there... some funny value getting mistakenly used?

Andrew, sticking this back to you since it looks like a prefs saving or loading issue.
Comment 5 Niklas Laxström 2009-06-23 06:14:50 UTC
r51910 might be related, or might not.
Comment 6 Andrew Garrett 2009-07-03 13:48:38 UTC
Is this still reproducible?
Comment 7 hanns-ulrich 2009-07-03 15:37:26 UTC
Yes, it is reproducible on de.wikimedia.org:
http://de.wikipedia.org/wiki/Benutzer:Florian_Gerlach_(Nawaro)/Inhalte_au%C3%9Fer_Artikel
Comment 8 Andrew Garrett 2009-07-16 17:07:58 UTC
(batch change)

Minor bugs that nevertheless need looking into
Comment 9 Andrew Garrett 2009-08-07 16:06:53 UTC
Hopefully resolved in r54585.

Note that you'll have to resave your preferences to fix it.
Comment 10 Brion Vibber 2009-08-19 02:33:29 UTC
Hmm... looks like the base problem is that empty is being interpreted as "put empty in the sig" instead of as "use default sig" at signature replacement time.

We shouldn't be saving the username into preferences if it hasn't been explicitly typed; if the user changes their name, they should automatically pick up the new value.

Reverted in r55306.
Comment 11 Aryeh Gregor (not reading bugmail, please e-mail directly) 2009-09-09 19:15:47 UTC
r56102 says it fixes this, so I'm closing as FIXED.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links