Last modified: 2009-07-17 20:58:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T21253, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 19253 - Update Wikimedia's NOC's highlight.php to not use non-breaking spaces
Update Wikimedia's NOC's highlight.php to not use non-breaking spaces
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
http://noc.wikimedia.org/conf/highlig...
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2009-06-17 06:18 UTC by MZMcBride
Modified: 2009-07-17 20:58 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description MZMcBride 2009-06-17 06:18:39 UTC 
Currently when you use highlight.php, it turns all spaces into non-breaking spaces. This dramatically inflates the page size. For larger files, this becomes very problematic (causes temporary browser locks, etc.).

I think taking the file contents and running them through GeSHi is probably best.

Example URL: http://noc.wikimedia.org/conf/highlight.php?file=flaggedrevs.php
Comment 1 Splarka 2009-06-17 06:26:05 UTC 
Or just stick it in <pre></pre> as literal plain text...
Comment 2 Brion Vibber 2009-07-17 20:58:21 UTC 
Done... swapped the &nbsp; for ' 's and wrapped in a <pre>. :)

Honestly this is going to be pretty small compared to the actual highlighting HTML though.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links