Last modified: 2014-11-18 18:07:07 UTC
Patrolling is disabled in huwiki through wgFlaggedRevsPatrolNamespaces = array(); but the red exclamation marks still show up on recentchanges. The bug appeared with the code update.
Sorry, messed up the component. This is a FlaggedRevs issue.
Assigning correctly.
(In reply to comment #0) > Patrolling is disabled in huwiki through wgFlaggedRevsPatrolNamespaces = > array(); but the red exclamation marks still show up on recentchanges. The bug > appeared with the code update. Unreviewed edits in review namespace still should have the ! marks.
(In reply to comment #3) > Unreviewed edits in review namespace still should have the ! marks. I have to admit I don't look at recentchanges a lot, but I was told these appeared after the code upgrade. Also, they have class="unpatrolled".
Any more info on these? What is the desired handling of the ! marks on this wiki?
Do they appear only if one has the patrolmarks right? If so, the source of confusion is probably that some of our patrollers (who are also admins) have it and some don't.
You need 'patrol' or 'patrolmarks', yes
Patrollers have 'patrol' (but not 'patrolmarks'). I asked one of them and he confirmed that they see the marks at the right place. It must have been a misunderstanding on my part.
Reopening and correcting the summary; the extra patrol marks appear on the watchlist, not on the recentchanges list. Try watching [[hu:Vita:Holokauszt]] or [[hu:Wikipédia:Kocsmafal (műszaki)]].
You are sure that it doesn't show on RC though?
(In reply to comment #10) > You are sure that it doesn't show on RC though? It does indeed. I'm pretty sure it didn't when I closed the bug on 06-21; though I'm not sure whether it showed on the watchlists then.
Per comment #3, isn't this the normal flaggedrevs behavior. Unreviewed revisions have ! marks to make them stand out in RC. There is no option to disable that currently.
(In reply to comment #12) > Per comment #3, isn't this the normal flaggedrevs behavior. Unreviewed > revisions have ! marks to make them stand out in RC. Even in namespaces that are neither reviewed nor patrolled? huwiki has the review feature enabled for main, Template, File and Portal, and the old patrolling for none; but the exclamation marks also appear in Talk, Project, User at least.
(In reply to comment #13) > (In reply to comment #12) > > Per comment #3, isn't this the normal flaggedrevs behavior. Unreviewed > > revisions have ! marks to make them stand out in RC. > Even in namespaces that are neither reviewed nor patrolled? huwiki has the > review feature enabled for main, Template, File and Portal, and the old > patrolling for none; but the exclamation marks also appear in Talk, Project, > User at least. Is that the issue? Changing summary then, so I know what's going on.
Seems to be an issue with $wgUseNPPatrol interpreted the same with flaggedrevs. $wgUseNPPatrol It should be turned off on huwiki to fix this.
To be sure, is it just new pages that have the ! marks that shouldn't have them?
No, all pages are affected. See e.g. the list of anon edits in the talk namespace: http://hu.wikipedia.org/w/index.php?namespace=1&hideliu=1&title=Speci%C3%A1lis%3AFriss+v%C3%A1ltoztat%C3%A1sok
http://noc.wikimedia.org/conf/highlight.php?file=InitialiseSettings.php I see the problem, $wgUseRCPatrol is already enabled, which makes flaggedrevs maintain the behavior of making everything patrollable.
OK, $wgUseRCPatrol and $wgUseNPPatrol disabled for huwiki. $wgFlaggedRevsPatrolNamespaces should be respected now (it includes no namespaces now).
