Last modified: 2009-07-25 21:16:07 UTC
Created attachment 6225 [details] screenshot of the problem in r51868, the value of width was changed from 20% to 30% for some adjustment and stuff. Unfortunately, this cases some labels as in Special:RecentChangesLinked to look over-margined as you can see in this attachment. Another thing, changing this value was because 'at' in "Display pages starting at:" (Special:AllPages) appears in new line. Well, 'at' still there in a new line on my machine. And when changing the value to 25% the sentence appears in single line. So, 'at' problem seems to be machine-dependent somehow, and it causes some visual problems the same time. I suggest reverting to the old value.
Created attachment 6226 [details] AllPages screenshot Screenshot of Special:AllPages to show the position of 'at'
It seems neither is a good solution, nor is changing it to 25%, because other forms will get issues. Getting rid of it altogether, as it was before r49790 is also an option[1]. According to the designer of the revised preferences, Special:Preferences may suffer, though. Which is the least of all evils, or what is a proper solution? Adding Andrew to cc. [1] r1=49544&r2=49790&pathrev=51868">http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/skins/common/shared.css?r1=49544&r2=49790&pathrev=51868
The columns should be the same width, and it should be reasonably narrow. It is hideous on some pages when there are multiple form tables and the columns have different widths. It is also hideous when there is a long description.
Created attachment 6227 [details] Prefs with 20% width Prefs with 20% width. Also uploading 30% width. Neither will win a design competition. Screenshot in Windows Xp with Firefox 3.0.11
Created attachment 6228 [details] Prefs with 30% width
Is there a way to change the mw-label to mw-label-preference use 20/25/30% in preferences only, and revert to the old behaviour in the rest of core (no width)? Also got a report that Special:Email is affected.
Created attachment 6238 [details] proposed patch (In reply to comment #6) > Is there a way to change the mw-label to mw-label-preference use 20/25/30% in > preferences only, and revert to the old behaviour in the rest of core (no > width)? Also got a report that Special:Email is affected. > Or something like this?
Created attachment 6243 [details] Special:Upload screenshot Special:Upload looks quite horrible too. It is a bad idea to apply the same spacing to a number of different interfaces.
Assigning to Andrew. Proposed patch looks OK, doesn't it?
Patch applied with modifications in r52737.
Why do tables have width: 100% applied to them? This broke stuff on enwiki's prefs page (see [[en:MediaWiki:Gadgets-prefstext]]).
